Commit bbedefcc authored by Michael Ellerman's avatar Michael Ellerman Committed by Jeff Garzik
Browse files

[PATCH] ibmveth: Harden driver initilisation 

This patch has been floating around for a while now, Santi originally
sent it in March: http://www.spinics.net/lists/netdev/msg00471.html



After a kexec the ibmveth driver will fail when trying to register
with the Hypervisor because the previous kernel has not unregistered.

So if the registration fails, we unregister and then try again.

We don't unconditionally unregister, because we don't want to disturb
the regular code path for 99% of users.

Signed-off-by: default avatarMichael Ellerman <michael@ellerman.id.au>
Acked-by: default avatarAnton Blanchard <anton@samba.org>
Signed-off-by: default avatarSantiago Leon <santil@us.ibm.com>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent 489b10c1

drivers/net/ibmveth.c

+26 −6
Original line number Diff line number Diff line
@@ -437,6 +437,31 @@ static void ibmveth_cleanup(struct ibmveth_adapter *adapter) 
						 &adapter->rx_buff_pool[i]);

}



static int ibmveth_register_logical_lan(struct ibmveth_adapter *adapter,

        union ibmveth_buf_desc rxq_desc, u64 mac_address)

{

	int rc, try_again = 1;



	/* After a kexec the adapter will still be open, so our attempt to

	* open it will fail. So if we get a failure we free the adapter and

	* try again, but only once. */

retry:

	rc = h_register_logical_lan(adapter->vdev->unit_address,

				    adapter->buffer_list_dma, rxq_desc.desc,

				    adapter->filter_list_dma, mac_address);



	if (rc != H_SUCCESS && try_again) {

		do {

			rc = h_free_logical_lan(adapter->vdev->unit_address);

		} while (H_IS_LONG_BUSY(rc) || (rc == H_BUSY));



		try_again = 0;

		goto retry;

	}



	return rc;

}



static int ibmveth_open(struct net_device *netdev)

{

	struct ibmveth_adapter *adapter = netdev->priv;
@@ -502,12 +527,7 @@ static int ibmveth_open(struct net_device *netdev) 
	ibmveth_debug_printk("filter list @ 0x%p\n", adapter->filter_list_addr);

	ibmveth_debug_printk("receive q   @ 0x%p\n", adapter->rx_queue.queue_addr);





	lpar_rc = h_register_logical_lan(adapter->vdev->unit_address,

					 adapter->buffer_list_dma,

					 rxq_desc.desc,

					 adapter->filter_list_dma,

					 mac_address);

	lpar_rc = ibmveth_register_logical_lan(adapter, rxq_desc, mac_address);



	if(lpar_rc != H_SUCCESS) {

		ibmveth_error_printk("h_register_logical_lan failed with %ld\n", lpar_rc);

CRA Git | Maintained and supported by SUSTech CRA and CCSE