Commit bbd9caa0 authored by Bernard Zhao's avatar Bernard Zhao Committed by Daniel Vetter
Browse files

gpu/drm: cleanup coding style a bit 



Remove first assignment to info which is meaningless.
Put the width and higth check first.
This change is to make the code a bit readable.

Signed-off-by: default avatarBernard Zhao <bernard@vivo.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20200907123129.27905-1-bernard@vivo.com
parent deb2464e

drivers/gpu/drm/drm_framebuffer.c

+4 −5
Original line number Diff line number Diff line
@@ -176,8 +176,7 @@ static int framebuffer_check(struct drm_device *dev, 
	int i;



	/* check if the format is supported at all */

	info = __drm_format_info(r->pixel_format);

	if (!info) {

	if (!__drm_format_info(r->pixel_format)) {

		struct drm_format_name_buf format_name;



		DRM_DEBUG_KMS("bad framebuffer format %s\n",
@@ -186,9 +185,6 @@ static int framebuffer_check(struct drm_device *dev, 
		return -EINVAL;

	}



	/* now let the driver pick its own format info */

	info = drm_get_format_info(dev, r);



	if (r->width == 0) {

		DRM_DEBUG_KMS("bad framebuffer width %u\n", r->width);

		return -EINVAL;
@@ -199,6 +195,9 @@ static int framebuffer_check(struct drm_device *dev, 
		return -EINVAL;

	}



	/* now let the driver pick its own format info */

	info = drm_get_format_info(dev, r);



	for (i = 0; i < info->num_planes; i++) {

		unsigned int width = fb_plane_width(r->width, info, i);

		unsigned int height = fb_plane_height(r->height, info, i);

CRA Git | Maintained and supported by SUSTech CRA and CCSE