Commit bbd562d7 authored Feb 21, 2011 by Wim Van Sebroeck

watchdog: cpwd: Fix buffer-overflow



cppcheck-1.47 reports:
[drivers/watchdog/cpwd.c:650]: (error) Buffer access out-of-bounds: p.devs

The source code is
	for (i = 0; i < 4; i++) {
		misc_deregister(&p->devs[i].misc);

where devs is defined as WD_NUMDEVS big and WD_NUMDEVS is equal to 3.
So the 4 should be a 3 or WD_NUMDEVS.

Reported-By: David Binderman
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>

parent c44ed965

drivers/watchdog/cpwd.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -646,7 +646,7 @@ static int __devexit cpwd_remove(struct platform_device *op)
		struct cpwd *p = dev_get_drvdata(&op->dev);
		int i;

		for (i = 0; i < 4; i++) {
		for (i = 0; i < WD_NUMDEVS; i++) {
		misc_deregister(&p->devs[i].misc);

		if (!p->enabled) {

Admin message