Unverified Commit bbd19cdc authored by Rander Wang's avatar Rander Wang Committed by Mark Brown
Browse files

ASoC: SOF: Intel: hda: add WAKEEN interrupt support for SoundWire 



When a SoundWire link is in clock stop state, a Slave device may wake
up the Master for some events such as jack detection. The WAKEEN
interrupt will be triggered and processed by the audio pci device.

If audio device is in D3, the interrupt will be routed to PME, or
aggregated at cAVS level as interrupt when audio device is in D0. This
patch only supports D3 case, where the audio pci device will be
resumed by a PME event and the WAKEEN interrupt will be processed
after audio pci device is powered up and ROM is initialized
successfully.

The WAKEEN handling is only enabled after the first boot due to
dependencies on a shim_lock mutex being initialized.

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: default avatarRander Wang <rander.wang@intel.com>
Link: https://lore.kernel.org/r/20200325215027.28716-10-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 02df8f43

sound/soc/sof/intel/hda-loader.c

+18 −0
Original line number Diff line number Diff line
@@ -346,6 +346,24 @@ int hda_dsp_cl_boot_firmware(struct snd_sof_dev *sdev) 
		goto cleanup;

	}



	/*

	 * When a SoundWire link is in clock stop state, a Slave

	 * device may trigger in-band wakes for events such as jack

	 * insertion or acoustic event detection. This event will lead

	 * to a WAKEEN interrupt, handled by the PCI device and routed

	 * to PME if the PCI device is in D3. The resume function in

	 * audio PCI driver will be invoked by ACPI for PME event and

	 * initialize the device and process WAKEEN interrupt.

	 *

	 * The WAKEEN interrupt should be processed ASAP to prevent an

	 * interrupt flood, otherwise other interrupts, such IPC,

	 * cannot work normally.  The WAKEEN is handled after the ROM

	 * is initialized successfully, which ensures power rails are

	 * enabled before accessing the SoundWire SHIM registers

	 */

	if (!sdev->first_boot)

		hda_sdw_process_wakeen(sdev);



	/*

	 * at this point DSP ROM has been initialized and

	 * should be ready for code loading and firmware boot

sound/soc/sof/intel/hda.c

+11 −0
Original line number Diff line number Diff line
@@ -241,6 +241,17 @@ static irqreturn_t hda_dsp_sdw_thread(int irq, void *context) 
	return sdw_intel_thread(irq, context);

}



void hda_sdw_process_wakeen(struct snd_sof_dev *sdev)

{

	struct sof_intel_hda_dev *hdev;



	hdev = sdev->pdata->hw_pdata;

	if (!hdev->sdw)

		return;



	sdw_intel_process_wakeen_event(hdev->sdw);

}



#endif



/*

sound/soc/sof/intel/hda.h

+5 −0
Original line number Diff line number Diff line
@@ -671,6 +671,7 @@ int hda_dsp_trace_trigger(struct snd_sof_dev *sdev, int cmd); 


int hda_sdw_startup(struct snd_sof_dev *sdev);

void hda_sdw_int_enable(struct snd_sof_dev *sdev, bool enable);

void hda_sdw_process_wakeen(struct snd_sof_dev *sdev);



#else
@@ -707,6 +708,10 @@ static inline irqreturn_t hda_dsp_sdw_thread(int irq, void *context) 
{

	return IRQ_HANDLED;

}



static inline void hda_sdw_process_wakeen(struct snd_sof_dev *sdev)

{

}

#endif



/* common dai driver */

CRA Git | Maintained and supported by SUSTech CRA and CCSE