Commit bbbd9995 authored Nov 14, 2007 by David P. Reed Committed by Thomas Gleixner Nov 17, 2007

x86: on x86_64, correct reading of PC RTC when update in progress in time_64.c



Correct potentially unstable PC RTC time register reading in time_64.c

Stop the use of an incorrect technique for reading the standard PC RTC
timer, which is documented to "disconnect" time registers from the bus
while updates are in progress.  The use of UIP flag while interrupts
are disabled to protect a 244 microsecond window is one of the
Motorola spec sheet's documented ways to read the RTC time registers
reliably.

tglx: removed locking changes from original patch, as they gain nothing
(read_persistent_clock is only called during boot, suspend, resume - so
no hot path affected) and conflict with the paravirt locking scheme
(see 32bit code), which we do not want to complicate for no benefit.

Signed-off-by: David P. Reed <dpreed@reed.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

parent c399da0d

arch/x86/kernel/time_64.c

+18 −12

Original line number	Diff line number	Diff line
		@@ -161,8 +161,16 @@ unsigned long read_persistent_clock(void)
		unsigned century = 0;

		spin_lock_irqsave(&rtc_lock, flags);
		/*
		* if UIP is clear, then we have >= 244 microseconds before RTC
		* registers will be updated. Spec sheet says that this is the
		* reliable way to read RTC - registers invalid (off bus) during update
		*/
		while ((CMOS_READ(RTC_FREQ_SELECT) & RTC_UIP))
		cpu_relax();

		do {

		/* now read all RTC registers while stable with interrupts disabled */
		sec = CMOS_READ(RTC_SECONDS);
		min = CMOS_READ(RTC_MINUTES);
		hour = CMOS_READ(RTC_HOURS);
		@@ -174,8 +182,6 @@ unsigned long read_persistent_clock(void)
		acpi_gbl_FADT.century)
		century = CMOS_READ(acpi_gbl_FADT.century);
		#endif
		} while (sec != CMOS_READ(RTC_SECONDS));

		spin_unlock_irqrestore(&rtc_lock, flags);

		/*

Admin message