Unverified Commit bbb7ad49 authored Apr 14, 2020 by Enric Balletbo i Serra Committed by Benson Leung May 04, 2020

platform/chrome: cros_usbpd_logger: Add __printf annotation to append_str()

This allows the compiler to verify the format strings vs the types of
the arguments. Also, silence the warning (triggered by W=1):

cros_usbpd_logger.c:55:2: warning: function ‘append_str’ might be a
candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]

Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: Benson Leung <bleung@chromium.org>

parent c032699e

drivers/platform/chrome/cros_usbpd_logger.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -46,6 +46,7 @@ static const char * const fault_names[] = {
		"---", "OCP", "fast OCP", "OVP", "Discharge"
		};

		__printf(3, 4)
		static int append_str(char buf, int pos, const char fmt, ...)
		{
		va_list args;