Commit bbae10fa authored May 08, 2020 by Bob Peterson Committed by Andreas Gruenbacher Jun 02, 2020

gfs2: Don't ignore inode write errors during inode_go_sync



Before for this patch, function inode_go_sync ignored io errors
during inode_go_sync, overwriting them with metadata write errors:

		error = filemap_fdatawait(mapping);
		mapping_set_error(mapping, error);
	}
	error = filemap_fdatawait(metamapping);
	...
	return error;

So any errors returned by the inode write would be forgotten if the
metadata write succeeded. This patch still does both writes, but
only sets error if it's still zero. That way, any errors will be
reported by to the caller, do_xmote, which will take appropriate
action and report the error.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>

parent 3700bec3

fs/gfs2/glops.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -268,7 +268,7 @@ static int inode_go_sync(struct gfs2_glock *gl)
		struct gfs2_inode *ip = gfs2_glock2inode(gl);
		int isreg = ip && S_ISREG(ip->i_inode.i_mode);
		struct address_space *metamapping = gfs2_glock2aspace(gl);
		int error = 0;
		int error = 0, ret;

		if (isreg) {
		if (test_and_clear_bit(GIF_SW_PAGED, &ip->i_flags))
		@@ -289,8 +289,10 @@ static int inode_go_sync(struct gfs2_glock *gl)
		error = filemap_fdatawait(mapping);
		mapping_set_error(mapping, error);
		}
		error = filemap_fdatawait(metamapping);
		mapping_set_error(metamapping, error);
		ret = filemap_fdatawait(metamapping);
		mapping_set_error(metamapping, ret);
		if (!error)
		error = ret;
		gfs2_ail_empty_gl(gl);
		/*
		* Writeback of the data mapping may cause the dirty flag to be set

Admin message