net/mlx5: Always Query HCA caps after setting them (bba1574c) · Commits · 戴 / test

Always query the HCA caps after setting them to update the capablities data structures. Not doing so results in incorrect capabilities being reported including max_dc, max_qp and several others. Fixes: ("net/mlx5: Split the load/unload flow into hardware and software flows") Signed-off-by:

Daniel Jurgens <danielj@mellanox.com> Signed-off-by:

Saeed Mahameed <saeedm@mellanox.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/mellanox/mlx5/core/main.c

+6 −6

Original line number	Diff line number	Diff line
		@@ -844,12 +844,6 @@ static int mlx5_init_once(struct mlx5_core_dev dev, struct mlx5_priv priv)
		struct pci_dev *pdev = dev->pdev;
		int err;

		err = mlx5_query_hca_caps(dev);
		if (err) {
		dev_err(&pdev->dev, "query hca failed\n");
		goto out;
		}

		err = mlx5_query_board_id(dev);
		if (err) {
		dev_err(&pdev->dev, "query board id failed\n");
		@@ -1023,6 +1017,12 @@ static int mlx5_load_one(struct mlx5_core_dev dev, struct mlx5_priv priv,

		mlx5_start_health_poll(dev);

		err = mlx5_query_hca_caps(dev);
		if (err) {
		dev_err(&pdev->dev, "query hca failed\n");
		goto err_stop_poll;
		}

		if (boot && mlx5_init_once(dev, priv)) {
		dev_err(&pdev->dev, "sw objs init failed\n");
		goto err_stop_poll;

Admin message