Commit bb8fe8ea authored Apr 21, 2017 by Ryosuke Saito Committed by Sebastian Reichel May 01, 2017

power: supply: sbs-battery: fix the sbs interrupt request



Since we use the default primary handler for the irq, IRQF_ONESHOT must
be set. Otherwise the request fails and the following errors are
displayed:

genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq 129
sbs-battery 0-000b: Failed to request irq: -22

Signed-off-by: Ryosuke Saito <raitosyo@gmail.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>

parent 46c202b5

drivers/power/supply/sbs-battery.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -820,7 +820,7 @@ static int sbs_probe(struct i2c_client *client,
		}

		rc = devm_request_threaded_irq(&client->dev, irq, NULL, sbs_irq,
		IRQF_TRIGGER_RISING \| IRQF_TRIGGER_FALLING,
		IRQF_TRIGGER_RISING \| IRQF_TRIGGER_FALLING \| IRQF_ONESHOT,
		dev_name(&client->dev), chip);
		if (rc) {
		dev_warn(&client->dev, "Failed to request irq: %d\n", rc);

Admin message