Commit bb8a954f authored Apr 09, 2007 by Patrick McHardy Committed by David S. Miller Apr 09, 2007

[NET_SCHED]: cls_tcindex: fix compatibility breakage



Userspace uses an integer for TCA_TCINDEX_SHIFT, the kernel was changed
to expect and use a u16 value in 2.6.11, which broke compatibility on
big endian machines. Change back to use int.

Reported by Ole Reinartz <ole.reinartz@gmx.de>

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 90f30ecc

net/sched/cls_tcindex.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -245,9 +245,9 @@ tcindex_set_parms(struct tcf_proto *tp, unsigned long base, u32 handle,
		}

		if (tb[TCA_TCINDEX_SHIFT-1]) {
		if (RTA_PAYLOAD(tb[TCA_TCINDEX_SHIFT-1]) < sizeof(u16))
		if (RTA_PAYLOAD(tb[TCA_TCINDEX_SHIFT-1]) < sizeof(int))
		goto errout;
		cp.shift = (u16 ) RTA_DATA(tb[TCA_TCINDEX_SHIFT-1]);
		cp.shift = (int ) RTA_DATA(tb[TCA_TCINDEX_SHIFT-1]);
		}

		err = -EBUSY;

Admin message