Commit bb899b89 authored May 10, 2011 by Sven Eckelmann

batman-adv: Ensure that we really have route changes in update_route

The debug output of update_route has tests for "route deleted" and "route
added". All other situations are handled as "route changed". This is not
true because neigh_node and curr_router could be both NULL.

The function is not called in this situation, but the code might be
interpreted wrong when reading it without this test.

Signed-off-by: Sven Eckelmann <sven@narfation.org>

parent 40219672

net/batman-adv/routing.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -108,7 +108,7 @@ static void update_route(struct bat_priv bat_priv, struct orig_node orig_node,
		tt_buff, tt_buff_len);

		/* route changed */
		} else {
		} else if (neigh_node && curr_router) {
		bat_dbg(DBG_ROUTES, bat_priv,
		"Changing route towards: %pM "
		"(now via %pM - was via %pM)\n",

Admin message