Commit bb8965bd authored Dec 28, 2018 by Michal Hocko Committed by Linus Torvalds Dec 28, 2018

mm, memory_hotplug: deobfuscate migration part of offlining

Memory migration might fail during offlining and we keep retrying in that
case.  This is currently obfuscated by goto retry loop.  The code is hard
to follow and as a result it is even suboptimal becase each retry round
scans the full range from start_pfn even though we have successfully
scanned/migrated [start_pfn, pfn] range already.  This is all only because
check_pages_isolated failure has to rescan the full range again.

De-obfuscate the migration retry loop by promoting it to a real for loop.
In fact remove the goto altogether by making it a proper double loop
(yeah, gotos are nasty in this specific case).  In the end we will get a
slightly more optimal code which is better readable.

[akpm@linux-foundation.org: reflow comments to 80 cols]
Link: http://lkml.kernel.org/r/20181211142741.2607-3-mhocko@kernel.org


Signed-off-by: Michal Hocko <mhocko@suse.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
Cc: Hugh Dickins <hughd@google.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: William Kucharski <william.kucharski@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent a85009c3

mm/memory_hotplug.c

+33 −29

Original line number	Diff line number	Diff line
		@@ -1607,11 +1607,10 @@ static int __ref __offline_pages(unsigned long start_pfn,
		goto failed_removal_isolated;
		}

		pfn = start_pfn;
		repeat:
		/* start memory hot removal */
		ret = -EINTR;
		do {
		for (pfn = start_pfn; pfn;) {
		if (signal_pending(current)) {
		ret = -EINTR;
		reason = "signal backoff";
		goto failed_removal_isolated;
		}
		@@ -1620,15 +1619,20 @@ repeat:
		lru_add_drain_all();
		drain_all_pages(zone);

		pfn = scan_movable_pages(start_pfn, end_pfn);
		if (pfn) { /* We have movable pages */
		ret = do_migrate_range(pfn, end_pfn);
		goto repeat;
		pfn = scan_movable_pages(pfn, end_pfn);
		if (pfn) {
		/*
		* TODO: fatal migration failures should bail
		* out
		*/
		do_migrate_range(pfn, end_pfn);
		}
		}

		/*
		* dissolve free hugepages in the memory block before doing offlining
		* actually in order to make hugetlbfs's object counting consistent.
		* Dissolve free hugepages in the memory block before doing
		* offlining actually in order to make hugetlbfs's object
		* counting consistent.
		*/
		ret = dissolve_free_huge_pages(start_pfn, end_pfn);
		if (ret) {
		@@ -1637,8 +1641,8 @@ repeat:
		}
		/* check again */
		offlined_pages = check_pages_isolated(start_pfn, end_pfn);
		if (offlined_pages < 0)
		goto repeat;
		} while (offlined_pages < 0);

		pr_info("Offlined Pages %ld\n", offlined_pages);
		/* Ok, all of our target is isolated.
		We cannot do rollback at this point. */

Admin message