Commit bb817bef authored by Ard Biesheuvel's avatar Ard Biesheuvel Committed by Ingo Molnar
Browse files

efi/arm: Enable DMI/SMBIOS 



Wire up the existing arm64 support for SMBIOS tables (aka DMI) for ARM as
well, by moving the arm64 init code to drivers/firmware/efi/arm-runtime.c
(which is shared between ARM and arm64), and adding a asm/dmi.h header to
ARM that defines the mapping routines for the firmware tables.

This allows userspace to access these tables to discover system information
exposed by the firmware. It also sets the hardware name used in crash
dumps, e.g.:

  Unable to handle kernel NULL pointer dereference at virtual address 00000000
  pgd = ed3c0000
  [00000000] *pgd=bf1f3835
  Internal error: Oops: 817 [#1] SMP THUMB2
  Modules linked in:
  CPU: 0 PID: 759 Comm: bash Not tainted 4.10.0-09601-g0e8f38792120-dirty #112
  Hardware name: QEMU KVM Virtual Machine, BIOS 0.0.0 02/06/2015
  ^^^

NOTE: This does *NOT* enable or encourage the use of DMI quirks, i.e., the
      the practice of identifying the platform via DMI to decide whether
      certain workarounds for buggy hardware and/or firmware need to be
      enabled. This would require the DMI subsystem to be enabled much
      earlier than we do on ARM, which is non-trivial.

Signed-off-by: default avatarArd Biesheuvel <ard.biesheuvel@linaro.org>
Acked-by: default avatarRussell King <rmk+kernel@armlinux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-efi@vger.kernel.org
Link: http://lkml.kernel.org/r/20170602135207.21708-14-ard.biesheuvel@linaro.org


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent ac81d3de

arch/arm/Kconfig

+17 −0
Original line number Diff line number Diff line
@@ -2061,6 +2061,23 @@ config EFI 
	  is only useful for kernels that may run on systems that have

	  UEFI firmware.



config DMI

	bool "Enable support for SMBIOS (DMI) tables"

	depends on EFI

	default y

	help

	  This enables SMBIOS/DMI feature for systems.



	  This option is only useful on systems that have UEFI firmware.

	  However, even with this option, the resultant kernel should

	  continue to boot on existing non-UEFI platforms.



	  NOTE: This does *NOT* enable or encourage the use of DMI quirks,

	  i.e., the the practice of identifying the platform via DMI to

	  decide whether certain workarounds for buggy hardware and/or

	  firmware need to be enabled. This would require the DMI subsystem

	  to be enabled much earlier than we do on ARM, which is non-trivial.



endmenu



menu "CPU Power Management"

arch/arm/include/asm/dmi.h

0 → 100644
+19 −0
Original line number Diff line number Diff line 
/*

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License version 2 as

 * published by the Free Software Foundation.

 */



#ifndef __ASM_DMI_H

#define __ASM_DMI_H



#include <linux/io.h>

#include <linux/slab.h>



#define dmi_early_remap(x, l)		memremap(x, l, MEMREMAP_WB)

#define dmi_early_unmap(x, l)		memunmap(x)

#define dmi_remap(x, l)			memremap(x, l, MEMREMAP_WB)

#define dmi_unmap(x)			memunmap(x)

#define dmi_alloc(l)			kzalloc(l, GFP_KERNEL)



#endif

arch/arm64/kernel/efi.c

+0 −15
Original line number Diff line number Diff line
@@ -11,7 +11,6 @@ 
 *

 */



#include <linux/dmi.h>

#include <linux/efi.h>

#include <linux/init.h>
@@ -117,20 +116,6 @@ int __init efi_set_mapping_permissions(struct mm_struct *mm, 
				   set_permissions, md);

}



static int __init arm64_dmi_init(void)

{

	/*

	 * On arm64, DMI depends on UEFI, and dmi_scan_machine() needs to

	 * be called early because dmi_id_init(), which is an arch_initcall

	 * itself, depends on dmi_scan_machine() having been called already.

	 */

	dmi_scan_machine();

	if (dmi_available)

		dmi_set_dump_stack_arch_desc();

	return 0;

}

core_initcall(arm64_dmi_init);



/*

 * UpdateCapsule() depends on the system being shutdown via

 * ResetSystem().

drivers/firmware/efi/arm-runtime.c

+16 −0
Original line number Diff line number Diff line
@@ -11,6 +11,7 @@ 
 *

 */



#include <linux/dmi.h>

#include <linux/efi.h>

#include <linux/io.h>

#include <linux/memblock.h>
@@ -166,3 +167,18 @@ void efi_virtmap_unload(void) 
	efi_set_pgd(current->active_mm);

	preempt_enable();

}





static int __init arm_dmi_init(void)

{

	/*

	 * On arm64/ARM, DMI depends on UEFI, and dmi_scan_machine() needs to

	 * be called early because dmi_id_init(), which is an arch_initcall

	 * itself, depends on dmi_scan_machine() having been called already.

	 */

	dmi_scan_machine();

	if (dmi_available)

		dmi_set_dump_stack_arch_desc();

	return 0;

}

core_initcall(arm_dmi_init);

CRA Git | Maintained and supported by SUSTech CRA and CCSE