net/mlx5: Provide simplified command interfaces (bb7fc863) · Commits · 戴 / test

Many mlx5_cmd_exec() callers are not interested in the output from that command or have standard in/out structures. Those callers simply allocate those structure on the stack and use sizeof() to provide in/out arguments. In this naive approach provide simplified versions of mlx5_cmd_exec(). Reviewed-by:

Saeed Mahameed <saeedm@mellanox.com> Signed-off-by:

Leon Romanovsky <leonro@mellanox.com>

include/linux/mlx5/driver.h

+13 −0

Original line number	Diff line number	Diff line
		@@ -903,6 +903,19 @@ int mlx5_cmd_exec_cb(struct mlx5_async_ctx ctx, void in, int in_size,

		int mlx5_cmd_exec(struct mlx5_core_dev dev, void in, int in_size, void *out,
		int out_size);

		#define mlx5_cmd_exec_inout(dev, ifc_cmd, in, out) \
		({ \
		mlx5_cmd_exec(dev, in, MLX5_ST_SZ_BYTES(ifc_cmd##_in), out, \
		MLX5_ST_SZ_BYTES(ifc_cmd##_out)); \
		})

		#define mlx5_cmd_exec_in(dev, ifc_cmd, in) \
		({ \
		u32 _out[MLX5_ST_SZ_DW(ifc_cmd##_out)] = {}; \
		mlx5_cmd_exec_inout(dev, ifc_cmd, in, _out); \
		})

		int mlx5_cmd_exec_polling(struct mlx5_core_dev dev, void in, int in_size,
		void *out, int out_size);
		void mlx5_cmd_mbox_status(void out, u8 status, u32 *syndrome);

Admin message