powerpc/pseries: remove prrn special case from DT update path (bb7c3d36) · Commits · 戴 / test

pseries_devicetree_update() is no longer called with PRRN_SCOPE. The purpose of prrn_update_node() was to remove and then add back a LMB whose NUMA assignment had changed. This has never been reliable, and this codepath has been default-disabled for several releases. Remove prrn_update_node(). Signed-off-by:

Nathan Lynch <nathanl@linux.ibm.com> Signed-off-by:

Michael Ellerman <mpe@ellerman.id.au> Link: https://lore.kernel.org/r/20200612051238.1007764-16-nathanl@linux.ibm.com

arch/powerpc/platforms/pseries/mobility.c

+0 −27

Original line number	Diff line number	Diff line
		@@ -244,29 +244,6 @@ static int add_dt_node(__be32 parent_phandle, __be32 drc_index)
		return rc;
		}

		static void prrn_update_node(__be32 phandle)
		{
		struct pseries_hp_errorlog hp_elog;
		struct device_node *dn;

		/*
		* If a node is found from a the given phandle, the phandle does not
		* represent the drc index of an LMB and we can ignore.
		*/
		dn = of_find_node_by_phandle(be32_to_cpu(phandle));
		if (dn) {
		of_node_put(dn);
		return;
		}

		hp_elog.resource = PSERIES_HP_ELOG_RESOURCE_MEM;
		hp_elog.action = PSERIES_HP_ELOG_ACTION_READD;
		hp_elog.id_type = PSERIES_HP_ELOG_ID_DRC_INDEX;
		hp_elog._drc_u.drc_index = phandle;

		handle_dlpar_errorlog(&hp_elog);
		}

		int pseries_devicetree_update(s32 scope)
		{
		char *rtas_buf;
		@@ -305,10 +282,6 @@ int pseries_devicetree_update(s32 scope)
		break;
		case UPDATE_DT_NODE:
		update_dt_node(phandle, scope);

		if (scope == PRRN_SCOPE)
		prrn_update_node(phandle);

		break;
		case ADD_DT_NODE:
		drc_index = *data++;

Admin message