veth: Remove useless veth field (bb7bba3d) · Commits · 戴 / test

The veth private structure contains a netdev pointer refering to its peer. This field is never used and it is pointless because if we can access, the veth_priv, that means we already have the netdev which is stored in veth_priv->dev. Signed-off-by:

Daniel Lezcano <dlezcano@fr.ibm.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/veth.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -30,7 +30,6 @@ struct veth_net_stats {

		struct veth_priv {
		struct net_device *peer;
		struct net_device *dev;
		struct list_head list;
		struct veth_net_stats *stats;
		unsigned ip_summed;
		@@ -420,12 +419,10 @@ static int veth_newlink(struct net_device *dev,
		*/

		priv = netdev_priv(dev);
		priv->dev = dev;
		priv->peer = peer;
		list_add(&priv->list, &veth_list);

		priv = netdev_priv(peer);
		priv->dev = peer;
		priv->peer = dev;
		INIT_LIST_HEAD(&priv->list);
		return 0;

Admin message