reset: remove remaining WARN_ON() in <linux/reset.h> (bb6c7768) · Commits · 戴 / test

Commit ("reset: make optional functions really optional") gave a new meaning to _get_optional variants. The differentiation by WARN_ON() is not needed any more. We already have inconsistency about this; (devm_)reset_control_get_exclusive() has WARN_ON() check, but of_reset_control_get_exclusive() does not. Signed-off-by:

Masahiro Yamada <yamada.masahiro@socionext.com> Signed-off-by:

Philipp Zabel <p.zabel@pengutronix.de>

include/linux/reset.h

+0 −6

Original line number	Diff line number	Diff line
		@@ -125,9 +125,6 @@ static inline int device_reset_optional(struct device *dev)
		static inline struct reset_control *
		__must_check reset_control_get_exclusive(struct device dev, const char id)
		{
		#ifndef CONFIG_RESET_CONTROLLER
		WARN_ON(1);
		#endif
		return __reset_control_get(dev, id, 0, false, false);
		}

		@@ -273,9 +270,6 @@ static inline struct reset_control *
		__must_check devm_reset_control_get_exclusive(struct device *dev,
		const char *id)
		{
		#ifndef CONFIG_RESET_CONTROLLER
		WARN_ON(1);
		#endif
		return __devm_reset_control_get(dev, id, 0, false, false);
		}

Admin message