Commit bb4f58a7 authored Mar 13, 2020 by Josef Bacik Committed by David Sterba May 25, 2020

btrfs: account for trans_block_rsv in may_commit_transaction



On ppc64le with 64k page size (respectively 64k block size) generic/320
was failing and debug output showed we were getting a premature ENOSPC
with a bunch of space in btrfs_fs_info::trans_block_rsv.

This meant there were still open transaction handles holding space, yet
the flusher didn't commit the transaction because it deemed the freed
space won't be enough to satisfy the current reserve ticket. Fix this
by accounting for space in trans_block_rsv when deciding whether the
current transaction should be committed or not.

Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Tested-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent e6549c2a

fs/btrfs/space-info.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -626,6 +626,7 @@ static int may_commit_transaction(struct btrfs_fs_info *fs_info,
		struct reserve_ticket *ticket = NULL;
		struct btrfs_block_rsv *delayed_rsv = &fs_info->delayed_block_rsv;
		struct btrfs_block_rsv *delayed_refs_rsv = &fs_info->delayed_refs_rsv;
		struct btrfs_block_rsv *trans_rsv = &fs_info->trans_block_rsv;
		struct btrfs_trans_handle *trans;
		u64 bytes_needed;
		u64 reclaim_bytes = 0;
		@@ -688,6 +689,11 @@ static int may_commit_transaction(struct btrfs_fs_info *fs_info,
		spin_lock(&delayed_refs_rsv->lock);
		reclaim_bytes += delayed_refs_rsv->reserved;
		spin_unlock(&delayed_refs_rsv->lock);

		spin_lock(&trans_rsv->lock);
		reclaim_bytes += trans_rsv->reserved;
		spin_unlock(&trans_rsv->lock);

		if (reclaim_bytes >= bytes_needed)
		goto commit;
		bytes_needed -= reclaim_bytes;

Admin message