Commit bb48eb9b authored Jan 23, 2020 by Kristian Evensen Committed by David S. Miller Jan 23, 2020

fou: Fix IPv6 netlink policy



When submitting v2 of "fou: Support binding FoU socket" (1713cb37),
I accidentally sent the wrong version of the patch and one fix was
missing. In the initial version of the patch, as well as the version 2
that I submitted, I incorrectly used ".type" for the two V6-attributes.
The correct is to use ".len".

Reported-by: Dmitry Vyukov <dvyukov@google.com>
Fixes: 1713cb37 ("fou: Support binding FoU socket")
Signed-off-by: Kristian Evensen <kristian.evensen@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 5169adbc

net/ipv4/fou.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -662,8 +662,8 @@ static const struct nla_policy fou_nl_policy[FOU_ATTR_MAX + 1] = {
		[FOU_ATTR_REMCSUM_NOPARTIAL] = { .type = NLA_FLAG, },
		[FOU_ATTR_LOCAL_V4] = { .type = NLA_U32, },
		[FOU_ATTR_PEER_V4] = { .type = NLA_U32, },
		[FOU_ATTR_LOCAL_V6] = { .type = sizeof(struct in6_addr), },
		[FOU_ATTR_PEER_V6] = { .type = sizeof(struct in6_addr), },
		[FOU_ATTR_LOCAL_V6] = { .len = sizeof(struct in6_addr), },
		[FOU_ATTR_PEER_V6] = { .len = sizeof(struct in6_addr), },
		[FOU_ATTR_PEER_PORT] = { .type = NLA_U16, },
		[FOU_ATTR_IFINDEX] = { .type = NLA_S32, },
		};

Admin message