Commit bb23800c authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Tomi Valkeinen
Browse files

drm/omap: Remove duplicate calls to .set_timings() operation 



The omap_dss_device .set_timings() operations are called directly from
omap_encoder_update(), and indirectly from the omap_dss_device .enable()
operation. The latter is called from omap_encoder_enable(), right after
calling omap_encoder_update(). The .set_timings() operation it thus
called twice in a row. Fix it by removing the indirect call.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: default avatarSebastian Reichel <sebastian.reichel@collabora.co.uk>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 8fe1d361

drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c

+0 −2
Original line number Diff line number Diff line
@@ -66,8 +66,6 @@ static int tvc_enable(struct omap_dss_device *dssdev) 
	if (omapdss_device_is_enabled(dssdev))

		return 0;



	src->ops->set_timings(src, &ddata->vm);



	r = src->ops->enable(src);

	if (r)

		return r;

drivers/gpu/drm/omapdrm/displays/connector-dvi.c

+0 −3
Original line number Diff line number Diff line
@@ -69,7 +69,6 @@ static void dvic_disconnect(struct omap_dss_device *src, 


static int dvic_enable(struct omap_dss_device *dssdev)

{

	struct panel_drv_data *ddata = to_panel_data(dssdev);

	struct omap_dss_device *src = dssdev->src;

	int r;
@@ -79,8 +78,6 @@ static int dvic_enable(struct omap_dss_device *dssdev) 
	if (omapdss_device_is_enabled(dssdev))

		return 0;



	src->ops->set_timings(src, &ddata->vm);



	r = src->ops->enable(src);

	if (r)

		return r;

drivers/gpu/drm/omapdrm/displays/connector-hdmi.c

+0 −2
Original line number Diff line number Diff line
@@ -71,8 +71,6 @@ static int hdmic_enable(struct omap_dss_device *dssdev) 
	if (omapdss_device_is_enabled(dssdev))

		return 0;



	src->ops->set_timings(src, &ddata->vm);



	r = src->ops->enable(src);

	if (r)

		return r;

drivers/gpu/drm/omapdrm/displays/encoder-opa362.c

+0 −2
Original line number Diff line number Diff line
@@ -57,8 +57,6 @@ static int opa362_enable(struct omap_dss_device *dssdev) 
	if (omapdss_device_is_enabled(dssdev))

		return 0;



	src->ops->set_timings(src, &ddata->vm);



	r = src->ops->enable(src);

	if (r)

		return r;

drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c

+0 −2
Original line number Diff line number Diff line
@@ -50,8 +50,6 @@ static int tfp410_enable(struct omap_dss_device *dssdev) 
	if (omapdss_device_is_enabled(dssdev))

		return 0;



	src->ops->set_timings(src, &ddata->vm);



	r = src->ops->enable(src);

	if (r)

		return r;

CRA Git | Maintained and supported by SUSTech CRA and CCSE