scripts/modpost: check for bad references in .pci.fixups area (bb15d8db) · Commits · 戴 / test

Functions used for PCI fixups (like DECLARE_PCI_FIXUP_HEADER) are often marked __init. This is okay as long as nobody is using PCI hotplug. However if one does execute | echo 1 > /sys/bus/pci/rescan and we hit a module which is marked __init istead of __devinit then we go boom because the code is removed after the kernel booted. This patch help to see those section mismatches. Cc: Michal Marek <mmarek@suse.cz> Cc: linux-kbuild@vger.kernel.org Cc: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by:

Sebastian Andrzej Siewior <sebastian@breakpoint.cc> Signed-off-by:

Bjorn Helgaas <bhelgaas@google.com>

scripts/mod/modpost.c

+11 −0

Original line number	Diff line number	Diff line
		@@ -865,6 +865,11 @@ static void check_section(const char modname, struct elf_info elf,
		#define ALL_EXIT_TEXT_SECTIONS \
		".exit.text$", ".devexit.text$", ".cpuexit.text$", ".memexit.text$"

		#define ALL_PCI_INIT_SECTIONS \
		".pci_fixup_early$", ".pci_fixup_header$", ".pci_fixup_final$", \
		".pci_fixup_enable$", ".pci_fixup_resume$", \
		".pci_fixup_resume_early$", ".pci_fixup_suspend$"

		#define ALL_XXXINIT_SECTIONS DEV_INIT_SECTIONS, CPU_INIT_SECTIONS, \
		MEM_INIT_SECTIONS
		#define ALL_XXXEXIT_SECTIONS DEV_EXIT_SECTIONS, CPU_EXIT_SECTIONS, \
		@@ -1027,6 +1032,12 @@ const struct sectioncheck sectioncheck[] = {
		.mismatch = ANY_EXIT_TO_ANY_INIT,
		.symbol_white_list = { DEFAULT_SYMBOL_WHITE_LIST, NULL },
		},
		{
		.fromsec = { ALL_PCI_INIT_SECTIONS, NULL },
		.tosec = { INIT_SECTIONS, NULL },
		.mismatch = ANY_INIT_TO_ANY_EXIT,
		.symbol_white_list = { NULL },
		},
		/* Do not export init/exit functions or data */
		{
		.fromsec = { "__ksymtab*", NULL },

Admin message