Commit bb08f92e authored by Mark Haverkamp's avatar Mark Haverkamp Committed by
Browse files

[SCSI] aacraid: use no_uld_attach flag 



Received From Mark Salyzyn.

In order to support user tools accessing the array components (SMART,
Mode Page information, Cache page adjustments, WWN determination,
Firmware updates etc), we take advantage of the no_uld_attach flag and
deprecate the code that filters Inquiries to block the requests to array
components. The quirk prevents the sd layer from attaching to the
components.

We also took the opportunity to balance the queue depths based on the
total adapter queue depth to the array devices to reduce the chances of
starvation.

Signed-off-by: default avatarMark Haverkamp <markh@osdl.org>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
parent bfb35aa8

drivers/scsi/aacraid/aachba.c

+3 −50
Original line number Diff line number Diff line
@@ -1465,7 +1465,7 @@ int aac_scsi_cmd(struct scsi_cmnd * scsicmd) 
	 *	itself.

	 */

	if (scmd_id(scsicmd) != host->this_id) {

		if ((scsicmd->device->channel == 0) ){

		if ((scsicmd->device->channel == CONTAINER_CHANNEL)) {

			if( (scsicmd->device->id >= dev->maximum_num_containers) || (scsicmd->device->lun != 0)){ 

				scsicmd->result = DID_NO_CONNECT << 16;

				scsicmd->scsi_done(scsicmd);
@@ -1935,33 +1935,7 @@ static void aac_srb_callback(void *context, struct fib * fibptr) 
	case SRB_STATUS_ERROR_RECOVERY:

	case SRB_STATUS_PENDING:

	case SRB_STATUS_SUCCESS:

		if(scsicmd->cmnd[0] == INQUIRY ){

			u8 b;

			u8 b1;

			/* We can't expose disk devices because we can't tell whether they

			 * are the raw container drives or stand alone drives.  If they have

			 * the removable bit set then we should expose them though.

			 */

			b = (*(u8*)scsicmd->buffer)&0x1f;

			b1 = ((u8*)scsicmd->buffer)[1];

			if( b==TYPE_TAPE || b==TYPE_WORM || b==TYPE_ROM || b==TYPE_MOD|| b==TYPE_MEDIUM_CHANGER 

					|| (b==TYPE_DISK && (b1&0x80)) ){

				scsicmd->result = DID_OK << 16 | COMMAND_COMPLETE << 8;

			/*

			 * We will allow disk devices if in RAID/SCSI mode and

			 * the channel is 2

			 */

			} else if ((dev->raid_scsi_mode) &&

					(scmd_channel(scsicmd) == 2)) {

				scsicmd->result = DID_OK << 16 | 

						COMMAND_COMPLETE << 8;

			} else {

				scsicmd->result = DID_NO_CONNECT << 16 | 

						COMMAND_COMPLETE << 8;

			}

		} else {

		scsicmd->result = DID_OK << 16 | COMMAND_COMPLETE << 8;

		}

		break;

	case SRB_STATUS_DATA_OVERRUN:

		switch(scsicmd->cmnd[0]){
@@ -1981,28 +1955,7 @@ static void aac_srb_callback(void *context, struct fib * fibptr) 
			scsicmd->result = DID_ERROR << 16 | COMMAND_COMPLETE << 8;

			break;

		case INQUIRY: {

			u8 b;

			u8 b1;

			/* We can't expose disk devices because we can't tell whether they

			* are the raw container drives or stand alone drives

			*/

			b = (*(u8*)scsicmd->buffer)&0x0f;

			b1 = ((u8*)scsicmd->buffer)[1];

			if( b==TYPE_TAPE || b==TYPE_WORM || b==TYPE_ROM || b==TYPE_MOD|| b==TYPE_MEDIUM_CHANGER

					|| (b==TYPE_DISK && (b1&0x80)) ){

			scsicmd->result = DID_OK << 16 | COMMAND_COMPLETE << 8;

			/*

			 * We will allow disk devices if in RAID/SCSI mode and

			 * the channel is 2

			 */

			} else if ((dev->raid_scsi_mode) &&

					(scmd_channel(scsicmd) == 2)) {

				scsicmd->result = DID_OK << 16 | 

						COMMAND_COMPLETE << 8;

			} else {

				scsicmd->result = DID_NO_CONNECT << 16 | 

						COMMAND_COMPLETE << 8;

			}

			break;

		}

		default:

drivers/scsi/aacraid/linit.c

+33 −9
Original line number Diff line number Diff line
@@ -385,20 +385,44 @@ static int aac_biosparm(struct scsi_device *sdev, struct block_device *bdev, 


static int aac_slave_configure(struct scsi_device *sdev)

{

	struct Scsi_Host *host = sdev->host;

	if (sdev_channel(sdev) == CONTAINER_CHANNEL) {

		sdev->skip_ms_page_8 = 1;

		sdev->skip_ms_page_3f = 1;

	}

	if ((sdev->type == TYPE_DISK) &&

			(sdev_channel(sdev) != CONTAINER_CHANNEL)) {

		struct aac_dev *aac = (struct aac_dev *)sdev->host->hostdata;

		if (!aac->raid_scsi_mode || (sdev_channel(sdev) != 2))

			sdev->no_uld_attach = 1;

	}

	if (sdev->tagged_supported && (sdev->type == TYPE_DISK) &&

			(sdev_channel(sdev) == CONTAINER_CHANNEL)) {

		struct scsi_device * dev;

		struct Scsi_Host *host = sdev->host;

		unsigned num_lsu = 0;

		unsigned num_one = 0;

		unsigned depth;



	if (sdev->tagged_supported)

		scsi_adjust_queue_depth(sdev, MSG_ORDERED_TAG, 128);

		__shost_for_each_device(dev, host) {

			if (dev->tagged_supported && (dev->type == TYPE_DISK) &&

				(sdev_channel(dev) == CONTAINER_CHANNEL))

				++num_lsu;

			else

		scsi_adjust_queue_depth(sdev, 0, 1);



	if (!(((struct aac_dev *)host->hostdata)->adapter_info.options

	  & AAC_OPT_NEW_COMM))

				++num_one;

		}

		if (num_lsu == 0)

			++num_lsu;

		depth = (host->can_queue - num_one) / num_lsu;

		if (depth > 256)

			depth = 256;

		else if (depth < 2)

			depth = 2;

		scsi_adjust_queue_depth(sdev, MSG_ORDERED_TAG, depth);

		if (!(((struct aac_dev *)host->hostdata)->adapter_info.options &

				AAC_OPT_NEW_COMM))

			blk_queue_max_segment_size(sdev->request_queue, 65536);

	} else

		scsi_adjust_queue_depth(sdev, 0, 1);



	return 0;

}
@@ -874,7 +898,7 @@ static int __devinit aac_probe_one(struct pci_dev *pdev, 
 

 	/*

	 * max channel will be the physical channels plus 1 virtual channel

	 * all containers are on the virtual channel 0

	 * all containers are on the virtual channel 0 (CONTAINER_CHANNEL)

	 * physical channels are address by their actual physical number+1

	 */

	if (aac->nondasd_support == 1)

CRA Git | Maintained and supported by SUSTech CRA and CCSE