Commit bb06b737 authored by Hartley Sweeten's avatar Hartley Sweeten Committed by Russell King
Browse files

ARM: 5881/1: vic.c: reorganize code 



This reorganizes the vic.c code in anticipation of a second patch
to use struct vic_device as the data stored in set_irq_chip_data().

The code now has the following flow:

1) struct vic_device definition, static variables, and to_vic()
   moved to the start of the code.
2) common code (vic_init2)
3) vic power management callbacks
4) vic power management initialization/registration
5) irq_chip callbacks
6) vendor specific vic initialization
7) vic initialization

In addition the typo vik_init_st is fixed (vic_init_st).

There is no functional change with this patch.

Tested-by: default avatarLinus Walleij <linus.walleij@stericsson.com>
Cc: Ben Dooks <ben-linux@fluff.org>
Cc: Alessandro Rubini <rubini-list@gnudd.com>

Comments from Hartley Sweeten:

 Please change from Cc to:
 Tested-by: default avatarAlessandro Rubini <rubini@unipv.it>
Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
parent 346e34ab

arch/arm/common/vic.c

+132 −133
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ 
 * along with this program; if not, write to the Free Software

 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA

 */



#include <linux/init.h>

#include <linux/list.h>

#include <linux/io.h>
@@ -28,48 +29,6 @@ 
#include <asm/mach/irq.h>

#include <asm/hardware/vic.h>



static void vic_ack_irq(unsigned int irq)

{

	void __iomem *base = get_irq_chip_data(irq);

	irq &= 31;

	writel(1 << irq, base + VIC_INT_ENABLE_CLEAR);

	/* moreover, clear the soft-triggered, in case it was the reason */

	writel(1 << irq, base + VIC_INT_SOFT_CLEAR);

}



static void vic_mask_irq(unsigned int irq)

{

	void __iomem *base = get_irq_chip_data(irq);

	irq &= 31;

	writel(1 << irq, base + VIC_INT_ENABLE_CLEAR);

}



static void vic_unmask_irq(unsigned int irq)

{

	void __iomem *base = get_irq_chip_data(irq);

	irq &= 31;

	writel(1 << irq, base + VIC_INT_ENABLE);

}



/**

 * vic_init2 - common initialisation code

 * @base: Base of the VIC.

 *

 * Common initialisation code for registeration

 * and resume.

*/

static void vic_init2(void __iomem *base)

{

	int i;



	for (i = 0; i < 16; i++) {

		void __iomem *reg = base + VIC_VECT_CNTL0 + (i * 4);

		writel(VIC_VECT_CNTL_ENABLE | i, reg);

	}



	writel(32, base + VIC_PL190_DEF_VECT_ADDR);

}



#if defined(CONFIG_PM)

/**

 * struct vic_device - VIC PM device
@@ -99,13 +58,34 @@ struct vic_device { 
/* we cannot allocate memory when VICs are initially registered */

static struct vic_device vic_devices[CONFIG_ARM_VIC_NR];



static int vic_id;



static inline struct vic_device *to_vic(struct sys_device *sys)

{

	return container_of(sys, struct vic_device, sysdev);

}

#endif /* CONFIG_PM */



static int vic_id;

/**

 * vic_init2 - common initialisation code

 * @base: Base of the VIC.

 *

 * Common initialisation code for registeration

 * and resume.

*/

static void vic_init2(void __iomem *base)

{

	int i;



	for (i = 0; i < 16; i++) {

		void __iomem *reg = base + VIC_VECT_CNTL0 + (i * 4);

		writel(VIC_VECT_CNTL_ENABLE | i, reg);

	}



	writel(32, base + VIC_PL190_DEF_VECT_ADDR);

}



#if defined(CONFIG_PM)

static int vic_class_resume(struct sys_device *dev)

{

	struct vic_device *vic = to_vic(dev);
@@ -158,31 +138,6 @@ struct sysdev_class vic_class = { 
	.resume		= vic_class_resume,

};



/**

 * vic_pm_register - Register a VIC for later power management control

 * @base: The base address of the VIC.

 * @irq: The base IRQ for the VIC.

 * @resume_sources: bitmask of interrupts allowed for resume sources.

 *

 * Register the VIC with the system device tree so that it can be notified

 * of suspend and resume requests and ensure that the correct actions are

 * taken to re-instate the settings on resume.

 */

static void __init vic_pm_register(void __iomem *base, unsigned int irq, u32 resume_sources)

{

	struct vic_device *v;



	if (vic_id >= ARRAY_SIZE(vic_devices))

		printk(KERN_ERR "%s: too few VICs, increase CONFIG_ARM_VIC_NR\n", __func__);

	else {

		v = &vic_devices[vic_id];

		v->base = base;

		v->resume_sources = resume_sources;

		v->irq = irq;

		vic_id++;

	}

}



/**

 * vic_pm_init - initicall to register VIC pm

 *
@@ -219,9 +174,60 @@ static int __init vic_pm_init(void) 


	return 0;

}



late_initcall(vic_pm_init);



/**

 * vic_pm_register - Register a VIC for later power management control

 * @base: The base address of the VIC.

 * @irq: The base IRQ for the VIC.

 * @resume_sources: bitmask of interrupts allowed for resume sources.

 *

 * Register the VIC with the system device tree so that it can be notified

 * of suspend and resume requests and ensure that the correct actions are

 * taken to re-instate the settings on resume.

 */

static void __init vic_pm_register(void __iomem *base, unsigned int irq, u32 resume_sources)

{

	struct vic_device *v;



	if (vic_id >= ARRAY_SIZE(vic_devices))

		printk(KERN_ERR "%s: too few VICs, increase CONFIG_ARM_VIC_NR\n", __func__);

	else {

		v = &vic_devices[vic_id];

		v->base = base;

		v->resume_sources = resume_sources;

		v->irq = irq;

		vic_id++;

	}

}

#else

static inline void vic_pm_register(void __iomem *base, unsigned int irq, u32 arg1) { }

#endif /* CONFIG_PM */



static void vic_ack_irq(unsigned int irq)

{

	void __iomem *base = get_irq_chip_data(irq);

	irq &= 31;

	writel(1 << irq, base + VIC_INT_ENABLE_CLEAR);

	/* moreover, clear the soft-triggered, in case it was the reason */

	writel(1 << irq, base + VIC_INT_SOFT_CLEAR);

}



static void vic_mask_irq(unsigned int irq)

{

	void __iomem *base = get_irq_chip_data(irq);

	irq &= 31;

	writel(1 << irq, base + VIC_INT_ENABLE_CLEAR);

}



static void vic_unmask_irq(unsigned int irq)

{

	void __iomem *base = get_irq_chip_data(irq);

	irq &= 31;

	writel(1 << irq, base + VIC_INT_ENABLE);

}



#if defined(CONFIG_PM)

static struct vic_device *vic_from_irq(unsigned int irq)

{

        struct vic_device *v = vic_devices;
@@ -255,10 +261,7 @@ static int vic_set_wake(unsigned int irq, unsigned int on) 


	return 0;

}



#else

static inline void vic_pm_register(void __iomem *base, unsigned int irq, u32 arg1) { }



#define vic_set_wake NULL

#endif /* CONFIG_PM */
@@ -270,43 +273,18 @@ static struct irq_chip vic_chip = { 
	.set_wake = vic_set_wake,

};



/* The PL190 cell from ARM has been modified by ST, so handle both here */

static void vik_init_st(void __iomem *base, unsigned int irq_start,

			 u32 vic_sources);



/**

 * vic_init - initialise a vectored interrupt controller

 * @base: iomem base address

 * @irq_start: starting interrupt number, must be muliple of 32

 * @vic_sources: bitmask of interrupt sources to allow

 * @resume_sources: bitmask of interrupt sources to allow for resume

/*

 * The PL190 cell from ARM has been modified by ST to handle 64 interrupts.

 * The original cell has 32 interrupts, while the modified one has 64,

 * replocating two blocks 0x00..0x1f in 0x20..0x3f. In that case

 * the probe function is called twice, with base set to offset 000

 *  and 020 within the page. We call this "second block".

 */

void __init vic_init(void __iomem *base, unsigned int irq_start,

		     u32 vic_sources, u32 resume_sources)

static void __init vic_init_st(void __iomem *base, unsigned int irq_start,

				u32 vic_sources)

{

	unsigned int i;

	u32 cellid = 0;

	enum amba_vendor vendor;



	/* Identify which VIC cell this one is, by reading the ID */

	for (i = 0; i < 4; i++) {

		u32 addr = ((u32)base & PAGE_MASK) + 0xfe0 + (i * 4);

		cellid |= (readl(addr) & 0xff) << (8 * i);

	}

	vendor = (cellid >> 12) & 0xff;

	printk(KERN_INFO "VIC @%p: id 0x%08x, vendor 0x%02x\n",

	       base, cellid, vendor);



	switch(vendor) {

	case AMBA_VENDOR_ST:

		vik_init_st(base, irq_start, vic_sources);

		return;

	default:

		printk(KERN_WARNING "VIC: unknown vendor, continuing anyways\n");

		/* fall through */

	case AMBA_VENDOR_ARM:

		break;

	}

	int vic_2nd_block = ((unsigned long)base & ~PAGE_MASK) != 0;



	/* Disable all interrupts initially. */
@@ -318,8 +296,12 @@ void __init vic_init(void __iomem *base, unsigned int irq_start, 
	writel(~0, base + VIC_INT_SOFT_CLEAR);



	/*

	 * Make sure we clear all existing interrupts

	 * Make sure we clear all existing interrupts. The vector registers

	 * in this cell are after the second block of general registers,

	 * so we can address them using standard offsets, but only from

	 * the second base address, which is 0x20 in the page

	 */

	if (vic_2nd_block) {

		writel(0, base + VIC_PL190_VECT_ADDR);

		for (i = 0; i < 19; i++) {

			unsigned int value;
@@ -327,8 +309,14 @@ void __init vic_init(void __iomem *base, unsigned int irq_start, 
			value = readl(base + VIC_PL190_VECT_ADDR);

			writel(value, base + VIC_PL190_VECT_ADDR);

		}

		/* ST has 16 vectors as well, but we don't enable them by now */

		for (i = 0; i < 16; i++) {

			void __iomem *reg = base + VIC_VECT_CNTL0 + (i * 4);

			writel(0, reg);

		}



	vic_init2(base);

		writel(32, base + VIC_PL190_DEF_VECT_ADDR);

	}



	for (i = 0; i < 32; i++) {

		if (vic_sources & (1 << i)) {
@@ -340,22 +328,41 @@ void __init vic_init(void __iomem *base, unsigned int irq_start, 
			set_irq_flags(irq, IRQF_VALID | IRQF_PROBE);

		}

	}



	vic_pm_register(base, irq_start, resume_sources);

}



/*

 * The PL190 cell from ARM has been modified by ST to handle 64 interrupts.

 * The original cell has 32 interrupts, while the modified one has 64,

 * replocating two blocks 0x00..0x1f in 0x20..0x3f. In that case

 * the probe function is called twice, with base set to offset 000

 *  and 020 within the page. We call this "second block".

/**

 * vic_init - initialise a vectored interrupt controller

 * @base: iomem base address

 * @irq_start: starting interrupt number, must be muliple of 32

 * @vic_sources: bitmask of interrupt sources to allow

 * @resume_sources: bitmask of interrupt sources to allow for resume

 */

static void __init vik_init_st(void __iomem *base, unsigned int irq_start,

				u32 vic_sources)

void __init vic_init(void __iomem *base, unsigned int irq_start,

		     u32 vic_sources, u32 resume_sources)

{

	unsigned int i;

	int vic_2nd_block = ((unsigned long)base & ~PAGE_MASK) != 0;

	u32 cellid = 0;

	enum amba_vendor vendor;



	/* Identify which VIC cell this one is, by reading the ID */

	for (i = 0; i < 4; i++) {

		u32 addr = ((u32)base & PAGE_MASK) + 0xfe0 + (i * 4);

		cellid |= (readl(addr) & 0xff) << (8 * i);

	}

	vendor = (cellid >> 12) & 0xff;

	printk(KERN_INFO "VIC @%p: id 0x%08x, vendor 0x%02x\n",

	       base, cellid, vendor);



	switch(vendor) {

	case AMBA_VENDOR_ST:

		vic_init_st(base, irq_start, vic_sources);

		return;

	default:

		printk(KERN_WARNING "VIC: unknown vendor, continuing anyways\n");

		/* fall through */

	case AMBA_VENDOR_ARM:

		break;

	}



	/* Disable all interrupts initially. */
@@ -367,12 +374,8 @@ static void __init vik_init_st(void __iomem *base, unsigned int irq_start, 
	writel(~0, base + VIC_INT_SOFT_CLEAR);



	/*

	 * Make sure we clear all existing interrupts. The vector registers

	 * in this cell are after the second block of general registers,

	 * so we can address them using standard offsets, but only from

	 * the second base address, which is 0x20 in the page

	 * Make sure we clear all existing interrupts

	 */

	if (vic_2nd_block) {

	writel(0, base + VIC_PL190_VECT_ADDR);

	for (i = 0; i < 19; i++) {

		unsigned int value;
@@ -380,14 +383,8 @@ static void __init vik_init_st(void __iomem *base, unsigned int irq_start, 
		value = readl(base + VIC_PL190_VECT_ADDR);

		writel(value, base + VIC_PL190_VECT_ADDR);

	}

		/* ST has 16 vectors as well, but we don't enable them by now */

		for (i = 0; i < 16; i++) {

			void __iomem *reg = base + VIC_VECT_CNTL0 + (i * 4);

			writel(0, reg);

		}



		writel(32, base + VIC_PL190_DEF_VECT_ADDR);

	}

	vic_init2(base);



	for (i = 0; i < 32; i++) {

		if (vic_sources & (1 << i)) {
@@ -399,4 +396,6 @@ static void __init vik_init_st(void __iomem *base, unsigned int irq_start, 
			set_irq_flags(irq, IRQF_VALID | IRQF_PROBE);

		}

	}



	vic_pm_register(base, irq_start, resume_sources);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE