Commit baff8da6 authored Oct 25, 2019 by Colin Ian King Committed by Kalle Valo Oct 31, 2019

rtw88: remove redundant null pointer check on arrays



The checks to see if swing_table->n or swing_table->p are null are
redundant since n and p are arrays and can never be null if
swing_table is non-null.  I believe these are redundant checks
and can be safely removed, especially the checks implies that these
are not arrays which can lead to confusion.

Addresses-Coverity: ("Array compared against 0")
Fixes: c97ee3e0 ("rtw88: add power tracking support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent 5195b904

drivers/net/wireless/realtek/rtw88/phy.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2059,7 +2059,7 @@ s8 rtw_phy_pwrtrack_get_pwridx(struct rtw_dev *rtwdev,
		return 0;
		}

		if (!swing_table \|\| !swing_table->n \|\| !swing_table->p) {
		if (!swing_table) {
		rtw_warn(rtwdev, "swing table not configured\n");
		return 0;
		}

Admin message