Commit baef653a authored by Philippe De Swert's avatar Philippe De Swert Committed by Felipe Balbi
Browse files

usb: musb: remove generic_interrupt 



This patch is based on the discussion of a previous patch to fix an issue
where the omap2430 musb driver is not working for N9/N950.

Moving all the interrupt handling to the devices. Avoids inclusion of generic
interrupt and breakage due to sometimes misleading CONFIG options. This makes
sure usb always works if on of the subdrivers is chosen. Tested on Nokia N9/N950.

Partially clean up CONFIG_SOC_OMAP3430 which is not necessary in the cases
where I removed it. Also helps with the removal work of those options that
Tony Lindgren predicted would happen at some point.

Signed-off-by: default avatarPhilippe De Swert <philippe.deswert@jollamobile.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 8b416b0b

drivers/usb/musb/musb_core.c

+2 −29
Original line number Diff line number Diff line
@@ -1501,33 +1501,6 @@ static int __devinit musb_core_init(u16 musb_type, struct musb *musb) 


/*-------------------------------------------------------------------------*/



#if defined(CONFIG_SOC_OMAP2430) || defined(CONFIG_SOC_OMAP3430) || \

	defined(CONFIG_ARCH_OMAP4) || defined(CONFIG_ARCH_U8500)



static irqreturn_t generic_interrupt(int irq, void *__hci)

{

	unsigned long	flags;

	irqreturn_t	retval = IRQ_NONE;

	struct musb	*musb = __hci;



	spin_lock_irqsave(&musb->lock, flags);



	musb->int_usb = musb_readb(musb->mregs, MUSB_INTRUSB);

	musb->int_tx = musb_readw(musb->mregs, MUSB_INTRTX);

	musb->int_rx = musb_readw(musb->mregs, MUSB_INTRRX);



	if (musb->int_usb || musb->int_tx || musb->int_rx)

		retval = musb_interrupt(musb);



	spin_unlock_irqrestore(&musb->lock, flags);



	return retval;

}



#else

#define generic_interrupt	NULL

#endif



/*

 * handle all the irqs defined by the HDRC core. for now we expect:  other

 * irq sources (phy, dma, etc) will be handled first, musb->int_* values
@@ -1896,7 +1869,8 @@ musb_init_controller(struct device *dev, int nIrq, void __iomem *ctrl) 
	musb->ops = plat->platform_ops;



	/* The musb_platform_init() call:

	 *   - adjusts musb->mregs and musb->isr if needed,

	 *   - adjusts musb->mregs

	 *   - sets the musb->isr

	 *   - may initialize an integrated tranceiver

	 *   - initializes musb->xceiv, usually by otg_get_phy()

	 *   - stops powering VBUS
@@ -1906,7 +1880,6 @@ musb_init_controller(struct device *dev, int nIrq, void __iomem *ctrl) 
	 * external/discrete ones in various flavors (twl4030 family,

	 * isp1504, non-OTG, etc) mostly hooking up through ULPI.

	 */

	musb->isr = generic_interrupt;

	status = musb_platform_init(musb);

	if (status < 0)

		goto fail1;

drivers/usb/musb/musbhsdma.h

+0 −4
Original line number Diff line number Diff line
@@ -31,10 +31,6 @@ 
 *

 */



#if defined(CONFIG_SOC_OMAP2430) || defined(CONFIG_SOC_OMAP3430)

#include "omap2430.h"

#endif



#ifndef CONFIG_BLACKFIN



#define MUSB_HSDMA_BASE		0x200

drivers/usb/musb/omap2430.c

+22 −0
Original line number Diff line number Diff line
@@ -333,6 +333,26 @@ static void omap_musb_mailbox_work(struct work_struct *mailbox_work) 
	omap_musb_set_mailbox(glue);

}



static irqreturn_t omap2430_musb_interrupt(int irq, void *__hci)

{

	unsigned long   flags;

	irqreturn_t     retval = IRQ_NONE;

	struct musb     *musb = __hci;



	spin_lock_irqsave(&musb->lock, flags);



	musb->int_usb = musb_readb(musb->mregs, MUSB_INTRUSB);

	musb->int_tx = musb_readw(musb->mregs, MUSB_INTRTX);

	musb->int_rx = musb_readw(musb->mregs, MUSB_INTRRX);



	if (musb->int_usb || musb->int_tx || musb->int_rx)

		retval = musb_interrupt(musb);



	spin_unlock_irqrestore(&musb->lock, flags);



	return retval;

}



static int omap2430_musb_init(struct musb *musb)

{

	u32 l;
@@ -352,6 +372,8 @@ static int omap2430_musb_init(struct musb *musb) 
		return -ENODEV;

	}



	musb->isr = omap2430_musb_interrupt;



	status = pm_runtime_get_sync(dev);

	if (status < 0) {

		dev_err(dev, "pm_runtime_get_sync FAILED %d\n", status);

drivers/usb/musb/ux500.c

+22 −0
Original line number Diff line number Diff line
@@ -36,6 +36,26 @@ struct ux500_glue { 
};

#define glue_to_musb(g)	platform_get_drvdata(g->musb)



static irqreturn_t ux500_musb_interrupt(int irq, void *__hci)

{

	unsigned long   flags;

	irqreturn_t     retval = IRQ_NONE;

	struct musb     *musb = __hci;



	spin_lock_irqsave(&musb->lock, flags);



	musb->int_usb = musb_readb(musb->mregs, MUSB_INTRUSB);

	musb->int_tx = musb_readw(musb->mregs, MUSB_INTRTX);

	musb->int_rx = musb_readw(musb->mregs, MUSB_INTRRX);



	if (musb->int_usb || musb->int_tx || musb->int_rx)

		retval = musb_interrupt(musb);



	spin_unlock_irqrestore(&musb->lock, flags);



	return retval;

}



static int ux500_musb_init(struct musb *musb)

{

	musb->xceiv = usb_get_phy(USB_PHY_TYPE_USB2);
@@ -44,6 +64,8 @@ static int ux500_musb_init(struct musb *musb) 
		return -ENODEV;

	}



	musb->isr = ux500_musb_interrupt;



	return 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE