Commit baeababb authored Nov 18, 2014 by Jason Wang Committed by David S. Miller Nov 19, 2014

tun: return NET_XMIT_DROP for dropped packets



After commit 5d097109
("tun: only queue packets on device"), NETDEV_TX_OK was returned for
dropped packets. This will confuse pktgen since dropped packets were
counted as sent ones.

Fixing this by returning NET_XMIT_DROP to let pktgen count it as error
packet.

Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent e3e32170

drivers/net/tun.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -819,7 +819,7 @@ drop:
		skb_tx_error(skb);
		kfree_skb(skb);
		rcu_read_unlock();
		return NETDEV_TX_OK;
		return NET_XMIT_DROP;
		}

		static void tun_net_mclist(struct net_device *dev)

Admin message