Commit bae361c5 authored Apr 26, 2020 by Michael Chan Committed by David S. Miller Apr 27, 2020

bnxt_en: Improve AER slot reset.



Improve the slot reset sequence by disabling the device to prevent bad
DMAs if slot reset fails.  Return the proper result instead of always
PCI_ERS_RESULT_RECOVERED to the caller.

Fixes: 6316ea6d ("bnxt_en: Enable AER support.")
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 9e68cb03

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+6 −3

Original line number	Diff line number	Diff line
		@@ -12212,12 +12212,15 @@ static pci_ers_result_t bnxt_io_slot_reset(struct pci_dev *pdev)
		bnxt_ulp_start(bp, err);
		}

		if (result != PCI_ERS_RESULT_RECOVERED && netif_running(netdev))
		if (result != PCI_ERS_RESULT_RECOVERED) {
		if (netif_running(netdev))
		dev_close(netdev);
		pci_disable_device(pdev);
		}

		rtnl_unlock();

		return PCI_ERS_RESULT_RECOVERED;
		return result;
		}

		/**

Admin message