Commit bae1320f authored Feb 25, 2019 by YueHaibing Committed by David S. Miller Feb 26, 2019

mlxsw: spectrum: remove set but not used variable 'autoneg_status'



Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/ethernet/mellanox/mlxsw/spectrum.c: In function 'mlxsw_sp_port_get_link_ksettings':
drivers/net/ethernet/mellanox/mlxsw/spectrum.c:3062:5: warning:
 variable 'autoneg_status' set but not used [-Wunused-but-set-variable]

It's not used since commit 475b33cb ("mlxsw: spectrum: Remove unsupported
eth_proto_lp_advertise field in PTYS")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 88ebbaf0

drivers/net/ethernet/mellanox/mlxsw/spectrum.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -3059,7 +3059,6 @@ static int mlxsw_sp_port_get_link_ksettings(struct net_device *dev,
		const struct mlxsw_sp_port_type_speed_ops *ops;
		char ptys_pl[MLXSW_REG_PTYS_LEN];
		u8 connector_type;
		u8 autoneg_status;
		bool autoneg;
		int err;

		@@ -3079,8 +3078,6 @@ static int mlxsw_sp_port_get_link_ksettings(struct net_device *dev,
		mlxsw_sp_port_get_link_advertise(mlxsw_sp, eth_proto_admin, autoneg,
		cmd);

		autoneg_status = mlxsw_reg_ptys_an_status_get(ptys_pl);

		cmd->base.autoneg = autoneg ? AUTONEG_ENABLE : AUTONEG_DISABLE;
		connector_type = mlxsw_reg_ptys_connector_type_get(ptys_pl);
		cmd->base.port = mlxsw_sp_port_connector_port(connector_type);

Admin message