Commit badc6198 authored by Tom Lendacky's avatar Tom Lendacky Committed by Ingo Molnar
Browse files

efi/x86: Add RNG seed EFI table to unencrypted mapping check 



When booting with SME active, EFI tables must be mapped unencrypted since
they were built by UEFI in unencrypted memory. Update the list of tables
to be checked during early_memremap() processing to account for the EFI
RNG seed table.

Signed-off-by: default avatarTom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: default avatarArd Biesheuvel <ardb@kernel.org>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Cc: linux-efi@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: David Hildenbrand <david@redhat.com>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
Link: https://lore.kernel.org/r/b64385fc13e5d7ad4b459216524f138e7879234f.1582662842.git.thomas.lendacky@amd.com
Link: https://lore.kernel.org/r/20200228121408.9075-3-ardb@kernel.org
parent f10e80a1

arch/x86/platform/efi/efi.c

+1 −0
Original line number Diff line number Diff line
@@ -90,6 +90,7 @@ static const unsigned long * const efi_tables[] = { 
#endif

	&efi.tpm_log,

	&efi.tpm_final_log,

	&efi_rng_seed,

};



u64 efi_setup;		/* efi setup_data physical address */

drivers/firmware/efi/efi.c

+10 −8
Original line number Diff line number Diff line
@@ -45,7 +45,7 @@ struct efi __read_mostly efi = { 
};

EXPORT_SYMBOL(efi);



static unsigned long __ro_after_init rng_seed = EFI_INVALID_TABLE_ADDR;

unsigned long __ro_after_init efi_rng_seed = EFI_INVALID_TABLE_ADDR;

static unsigned long __initdata mem_reserve = EFI_INVALID_TABLE_ADDR;

static unsigned long __initdata rt_prop = EFI_INVALID_TABLE_ADDR;
@@ -451,7 +451,7 @@ static const efi_config_table_type_t common_tables[] __initconst = { 
	{SMBIOS3_TABLE_GUID, "SMBIOS 3.0", &efi.smbios3},

	{EFI_SYSTEM_RESOURCE_TABLE_GUID, "ESRT", &efi.esrt},

	{EFI_MEMORY_ATTRIBUTES_TABLE_GUID, "MEMATTR", &efi_mem_attr_table},

	{LINUX_EFI_RANDOM_SEED_TABLE_GUID, "RNG", &rng_seed},

	{LINUX_EFI_RANDOM_SEED_TABLE_GUID, "RNG", &efi_rng_seed},

	{LINUX_EFI_TPM_EVENT_LOG_GUID, "TPMEventLog", &efi.tpm_log},

	{LINUX_EFI_TPM_FINAL_LOG_GUID, "TPMFinalLog", &efi.tpm_final_log},

	{LINUX_EFI_MEMRESERVE_TABLE_GUID, "MEMRESERVE", &mem_reserve},
@@ -519,11 +519,11 @@ int __init efi_config_parse_tables(const efi_config_table_t *config_tables, 
	pr_cont("\n");

	set_bit(EFI_CONFIG_TABLES, &efi.flags);



	if (rng_seed != EFI_INVALID_TABLE_ADDR) {

	if (efi_rng_seed != EFI_INVALID_TABLE_ADDR) {

		struct linux_efi_random_seed *seed;

		u32 size = 0;



		seed = early_memremap(rng_seed, sizeof(*seed));

		seed = early_memremap(efi_rng_seed, sizeof(*seed));

		if (seed != NULL) {

			size = seed->size;

			early_memunmap(seed, sizeof(*seed));
@@ -531,7 +531,8 @@ int __init efi_config_parse_tables(const efi_config_table_t *config_tables, 
			pr_err("Could not map UEFI random seed!\n");

		}

		if (size > 0) {

			seed = early_memremap(rng_seed, sizeof(*seed) + size);

			seed = early_memremap(efi_rng_seed,

					      sizeof(*seed) + size);

			if (seed != NULL) {

				pr_notice("seeding entropy pool\n");

				add_bootloader_randomness(seed->bits, seed->size);
@@ -923,7 +924,7 @@ static int update_efi_random_seed(struct notifier_block *nb, 
	if (!kexec_in_progress)

		return NOTIFY_DONE;



	seed = memremap(rng_seed, sizeof(*seed), MEMREMAP_WB);

	seed = memremap(efi_rng_seed, sizeof(*seed), MEMREMAP_WB);

	if (seed != NULL) {

		size = min(seed->size, EFI_RANDOM_SEED_SIZE);

		memunmap(seed);
@@ -931,7 +932,8 @@ static int update_efi_random_seed(struct notifier_block *nb, 
		pr_err("Could not map UEFI random seed!\n");

	}

	if (size > 0) {

		seed = memremap(rng_seed, sizeof(*seed) + size, MEMREMAP_WB);

		seed = memremap(efi_rng_seed, sizeof(*seed) + size,

				MEMREMAP_WB);

		if (seed != NULL) {

			seed->size = size;

			get_random_bytes(seed->bits, seed->size);
@@ -949,7 +951,7 @@ static struct notifier_block efi_random_seed_nb = { 


static int __init register_update_efi_random_seed(void)

{

	if (rng_seed == EFI_INVALID_TABLE_ADDR)

	if (efi_rng_seed == EFI_INVALID_TABLE_ADDR)

		return 0;

	return register_reboot_notifier(&efi_random_seed_nb);

}

include/linux/efi.h

+2 −0
Original line number Diff line number Diff line
@@ -526,6 +526,8 @@ typedef struct { 
	efi_time_t time_of_revocation;

} efi_cert_x509_sha256_t;



extern unsigned long __ro_after_init efi_rng_seed;		/* RNG Seed table */



/*

 * All runtime access to EFI goes through this structure:

 */

CRA Git | Maintained and supported by SUSTech CRA and CCSE