Commit baacd53a authored by Nishka Dasgupta's avatar Nishka Dasgupta Committed by Greg Kroah-Hartman
Browse files

staging: greybus: Replace function gb_i2c_device_setup() 



Remove function gb_i2c_device_setup as all it does is call
gb_i2c_functionality_operation.
Rename gb_i2c_functionality_operation to gb_i2c_device_setup to maintain
compatibility with call sites.
Issue found with Coccinelle.

Signed-off-by: default avatarNishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lore.kernel.org/r/20190705131131.27354-1-nishkadg.linux@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ebf256e3

drivers/staging/greybus/i2c.c

+8 −14
Original line number Diff line number Diff line
@@ -31,7 +31,14 @@ static u32 gb_i2c_functionality_map(u32 gb_i2c_functionality) 
	return gb_i2c_functionality;	/* All bits the same for now */

}



static int gb_i2c_functionality_operation(struct gb_i2c_device *gb_i2c_dev)

/*

 * Do initial setup of the i2c device.  This includes verifying we

 * can support it (based on the protocol version it advertises).

 * If that's OK, we get and cached its functionality bits.

 *

 * Note: gb_i2c_dev->connection is assumed to have been valid.

 */

static int gb_i2c_device_setup(struct gb_i2c_device *gb_i2c_dev)

{

	struct gb_i2c_functionality_response response;

	u32 functionality;
@@ -235,19 +242,6 @@ static const struct i2c_algorithm gb_i2c_algorithm = { 
	.functionality	= gb_i2c_functionality,

};



/*

 * Do initial setup of the i2c device.  This includes verifying we

 * can support it (based on the protocol version it advertises).

 * If that's OK, we get and cached its functionality bits.

 *

 * Note: gb_i2c_dev->connection is assumed to have been valid.

 */

static int gb_i2c_device_setup(struct gb_i2c_device *gb_i2c_dev)

{

	/* Assume the functionality never changes, just get it once */

	return gb_i2c_functionality_operation(gb_i2c_dev);

}



static int gb_i2c_probe(struct gbphy_device *gbphy_dev,

			const struct gbphy_device_id *id)

{

CRA Git | Maintained and supported by SUSTech CRA and CCSE