Commit ba95fd47 authored by Linus Torvalds's avatar Linus Torvalds
Browse files

Merge branch 'for-linus' of git://git.kernel.dk/linux-2.6-block 

* 'for-linus' of git://git.kernel.dk/linux-2.6-block:
  block: fix deadlock in blk_abort_queue() for drivers that readd to timeout list
  block: fix booting from partitioned md array
  block: revert part of 18ce3751
  cciss: PCI power management reset for kexec
  paride/pg.c: xs(): &&/|| confusion
  fs/bio: bio_alloc_bioset: pass right object ptr to mempool_free
  block: fix bad definition of BIO_RW_SYNC
  bsg: Fix sense buffer bug in SG_IO
parents 59af0a0b be987fdb

block/blk-timeout.c

+8 −1
Original line number Diff line number Diff line
@@ -209,12 +209,19 @@ void blk_abort_queue(struct request_queue *q) 
{

	unsigned long flags;

	struct request *rq, *tmp;

	LIST_HEAD(list);



	spin_lock_irqsave(q->queue_lock, flags);



	elv_abort_queue(q);



	list_for_each_entry_safe(rq, tmp, &q->timeout_list, timeout_list)

	/*

	 * Splice entries to local list, to avoid deadlocking if entries

	 * get readded to the timeout list by error handling

	 */

	list_splice_init(&q->timeout_list, &list);



	list_for_each_entry_safe(rq, tmp, &list, timeout_list)

		blk_abort_request(rq);



	spin_unlock_irqrestore(q->queue_lock, flags);

block/blktrace.c

+1 −1
Original line number Diff line number Diff line
@@ -142,7 +142,7 @@ static void __blk_add_trace(struct blk_trace *bt, sector_t sector, int bytes, 


	what |= ddir_act[rw & WRITE];

	what |= MASK_TC_BIT(rw, BARRIER);

	what |= MASK_TC_BIT(rw, SYNC);

	what |= MASK_TC_BIT(rw, SYNCIO);

	what |= MASK_TC_BIT(rw, AHEAD);

	what |= MASK_TC_BIT(rw, META);

	what |= MASK_TC_BIT(rw, DISCARD);

block/bsg.c

+10 −7
Original line number Diff line number Diff line
@@ -244,7 +244,8 @@ bsg_validate_sgv4_hdr(struct request_queue *q, struct sg_io_v4 *hdr, int *rw) 
 * map sg_io_v4 to a request.

 */

static struct request *

bsg_map_hdr(struct bsg_device *bd, struct sg_io_v4 *hdr, fmode_t has_write_perm)

bsg_map_hdr(struct bsg_device *bd, struct sg_io_v4 *hdr, fmode_t has_write_perm,

	    u8 *sense)

{

	struct request_queue *q = bd->queue;

	struct request *rq, *next_rq = NULL;
@@ -306,6 +307,10 @@ bsg_map_hdr(struct bsg_device *bd, struct sg_io_v4 *hdr, fmode_t has_write_perm) 
		if (ret)

			goto out;

	}



	rq->sense = sense;

	rq->sense_len = 0;



	return rq;

out:

	if (rq->cmd != rq->__cmd)
@@ -348,9 +353,6 @@ static void bsg_rq_end_io(struct request *rq, int uptodate) 
static void bsg_add_command(struct bsg_device *bd, struct request_queue *q,

			    struct bsg_command *bc, struct request *rq)

{

	rq->sense = bc->sense;

	rq->sense_len = 0;



	/*

	 * add bc command to busy queue and submit rq for io

	 */
@@ -419,7 +421,7 @@ static int blk_complete_sgv4_hdr_rq(struct request *rq, struct sg_io_v4 *hdr, 
{

	int ret = 0;



	dprintk("rq %p bio %p %u\n", rq, bio, rq->errors);

	dprintk("rq %p bio %p 0x%x\n", rq, bio, rq->errors);

	/*

	 * fill in all the output members

	 */
@@ -635,7 +637,7 @@ static int __bsg_write(struct bsg_device *bd, const char __user *buf, 
		/*

		 * get a request, fill in the blanks, and add to request queue

		 */

		rq = bsg_map_hdr(bd, &bc->hdr, has_write_perm);

		rq = bsg_map_hdr(bd, &bc->hdr, has_write_perm, bc->sense);

		if (IS_ERR(rq)) {

			ret = PTR_ERR(rq);

			rq = NULL;
@@ -922,11 +924,12 @@ static long bsg_ioctl(struct file *file, unsigned int cmd, unsigned long arg) 
		struct request *rq;

		struct bio *bio, *bidi_bio = NULL;

		struct sg_io_v4 hdr;

		u8 sense[SCSI_SENSE_BUFFERSIZE];



		if (copy_from_user(&hdr, uarg, sizeof(hdr)))

			return -EFAULT;



		rq = bsg_map_hdr(bd, &hdr, file->f_mode & FMODE_WRITE);

		rq = bsg_map_hdr(bd, &hdr, file->f_mode & FMODE_WRITE, sense);

		if (IS_ERR(rq))

			return PTR_ERR(rq);

block/genhd.c

+8 −0
Original line number Diff line number Diff line
@@ -1087,6 +1087,14 @@ dev_t blk_lookup_devt(const char *name, int partno) 
		if (strcmp(dev_name(dev), name))

			continue;



		if (partno < disk->minors) {

			/* We need to return the right devno, even

			 * if the partition doesn't exist yet.

			 */

			devt = MKDEV(MAJOR(dev->devt),

				     MINOR(dev->devt) + partno);

			break;

		}

		part = disk_get_part(disk, partno);

		if (part) {

			devt = part_devt(part);

drivers/block/cciss.c

+215 −0
Original line number Diff line number Diff line
@@ -3390,6 +3390,203 @@ static void free_hba(int i) 
	kfree(p);

}



/* Send a message CDB to the firmware. */

static __devinit int cciss_message(struct pci_dev *pdev, unsigned char opcode, unsigned char type)

{

	typedef struct {

		CommandListHeader_struct CommandHeader;

		RequestBlock_struct Request;

		ErrDescriptor_struct ErrorDescriptor;

	} Command;

	static const size_t cmd_sz = sizeof(Command) + sizeof(ErrorInfo_struct);

	Command *cmd;

	dma_addr_t paddr64;

	uint32_t paddr32, tag;

	void __iomem *vaddr;

	int i, err;



	vaddr = ioremap_nocache(pci_resource_start(pdev, 0), pci_resource_len(pdev, 0));

	if (vaddr == NULL)

		return -ENOMEM;



	/* The Inbound Post Queue only accepts 32-bit physical addresses for the

	   CCISS commands, so they must be allocated from the lower 4GiB of

	   memory. */

	err = pci_set_consistent_dma_mask(pdev, DMA_32BIT_MASK);

	if (err) {

		iounmap(vaddr);

		return -ENOMEM;

	}



	cmd = pci_alloc_consistent(pdev, cmd_sz, &paddr64);

	if (cmd == NULL) {

		iounmap(vaddr);

		return -ENOMEM;

	}



	/* This must fit, because of the 32-bit consistent DMA mask.  Also,

	   although there's no guarantee, we assume that the address is at

	   least 4-byte aligned (most likely, it's page-aligned). */

	paddr32 = paddr64;



	cmd->CommandHeader.ReplyQueue = 0;

	cmd->CommandHeader.SGList = 0;

	cmd->CommandHeader.SGTotal = 0;

	cmd->CommandHeader.Tag.lower = paddr32;

	cmd->CommandHeader.Tag.upper = 0;

	memset(&cmd->CommandHeader.LUN.LunAddrBytes, 0, 8);



	cmd->Request.CDBLen = 16;

	cmd->Request.Type.Type = TYPE_MSG;

	cmd->Request.Type.Attribute = ATTR_HEADOFQUEUE;

	cmd->Request.Type.Direction = XFER_NONE;

	cmd->Request.Timeout = 0; /* Don't time out */

	cmd->Request.CDB[0] = opcode;

	cmd->Request.CDB[1] = type;

	memset(&cmd->Request.CDB[2], 0, 14); /* the rest of the CDB is reserved */



	cmd->ErrorDescriptor.Addr.lower = paddr32 + sizeof(Command);

	cmd->ErrorDescriptor.Addr.upper = 0;

	cmd->ErrorDescriptor.Len = sizeof(ErrorInfo_struct);



	writel(paddr32, vaddr + SA5_REQUEST_PORT_OFFSET);



	for (i = 0; i < 10; i++) {

		tag = readl(vaddr + SA5_REPLY_PORT_OFFSET);

		if ((tag & ~3) == paddr32)

			break;

		schedule_timeout_uninterruptible(HZ);

	}



	iounmap(vaddr);



	/* we leak the DMA buffer here ... no choice since the controller could

	   still complete the command. */

	if (i == 10) {

		printk(KERN_ERR "cciss: controller message %02x:%02x timed out\n",

			opcode, type);

		return -ETIMEDOUT;

	}



	pci_free_consistent(pdev, cmd_sz, cmd, paddr64);



	if (tag & 2) {

		printk(KERN_ERR "cciss: controller message %02x:%02x failed\n",

			opcode, type);

		return -EIO;

	}



	printk(KERN_INFO "cciss: controller message %02x:%02x succeeded\n",

		opcode, type);

	return 0;

}



#define cciss_soft_reset_controller(p) cciss_message(p, 1, 0)

#define cciss_noop(p) cciss_message(p, 3, 0)



static __devinit int cciss_reset_msi(struct pci_dev *pdev)

{

/* the #defines are stolen from drivers/pci/msi.h. */

#define msi_control_reg(base)		(base + PCI_MSI_FLAGS)

#define PCI_MSIX_FLAGS_ENABLE		(1 << 15)



	int pos;

	u16 control = 0;



	pos = pci_find_capability(pdev, PCI_CAP_ID_MSI);

	if (pos) {

		pci_read_config_word(pdev, msi_control_reg(pos), &control);

		if (control & PCI_MSI_FLAGS_ENABLE) {

			printk(KERN_INFO "cciss: resetting MSI\n");

			pci_write_config_word(pdev, msi_control_reg(pos), control & ~PCI_MSI_FLAGS_ENABLE);

		}

	}



	pos = pci_find_capability(pdev, PCI_CAP_ID_MSIX);

	if (pos) {

		pci_read_config_word(pdev, msi_control_reg(pos), &control);

		if (control & PCI_MSIX_FLAGS_ENABLE) {

			printk(KERN_INFO "cciss: resetting MSI-X\n");

			pci_write_config_word(pdev, msi_control_reg(pos), control & ~PCI_MSIX_FLAGS_ENABLE);

		}

	}



	return 0;

}



/* This does a hard reset of the controller using PCI power management

 * states. */

static __devinit int cciss_hard_reset_controller(struct pci_dev *pdev)

{

	u16 pmcsr, saved_config_space[32];

	int i, pos;



	printk(KERN_INFO "cciss: using PCI PM to reset controller\n");



	/* This is very nearly the same thing as



	   pci_save_state(pci_dev);

	   pci_set_power_state(pci_dev, PCI_D3hot);

	   pci_set_power_state(pci_dev, PCI_D0);

	   pci_restore_state(pci_dev);



	   but we can't use these nice canned kernel routines on

	   kexec, because they also check the MSI/MSI-X state in PCI

	   configuration space and do the wrong thing when it is

	   set/cleared.  Also, the pci_save/restore_state functions

	   violate the ordering requirements for restoring the

	   configuration space from the CCISS document (see the

	   comment below).  So we roll our own .... */



	for (i = 0; i < 32; i++)

		pci_read_config_word(pdev, 2*i, &saved_config_space[i]);



	pos = pci_find_capability(pdev, PCI_CAP_ID_PM);

	if (pos == 0) {

		printk(KERN_ERR "cciss_reset_controller: PCI PM not supported\n");

		return -ENODEV;

	}



	/* Quoting from the Open CISS Specification: "The Power

	 * Management Control/Status Register (CSR) controls the power

	 * state of the device.  The normal operating state is D0,

	 * CSR=00h.  The software off state is D3, CSR=03h.  To reset

	 * the controller, place the interface device in D3 then to

	 * D0, this causes a secondary PCI reset which will reset the

	 * controller." */



	/* enter the D3hot power management state */

	pci_read_config_word(pdev, pos + PCI_PM_CTRL, &pmcsr);

	pmcsr &= ~PCI_PM_CTRL_STATE_MASK;

	pmcsr |= PCI_D3hot;

	pci_write_config_word(pdev, pos + PCI_PM_CTRL, pmcsr);



	schedule_timeout_uninterruptible(HZ >> 1);



	/* enter the D0 power management state */

	pmcsr &= ~PCI_PM_CTRL_STATE_MASK;

	pmcsr |= PCI_D0;

	pci_write_config_word(pdev, pos + PCI_PM_CTRL, pmcsr);



	schedule_timeout_uninterruptible(HZ >> 1);



	/* Restore the PCI configuration space.  The Open CISS

	 * Specification says, "Restore the PCI Configuration

	 * Registers, offsets 00h through 60h. It is important to

	 * restore the command register, 16-bits at offset 04h,

	 * last. Do not restore the configuration status register,

	 * 16-bits at offset 06h."  Note that the offset is 2*i. */

	for (i = 0; i < 32; i++) {

		if (i == 2 || i == 3)

			continue;

		pci_write_config_word(pdev, 2*i, saved_config_space[i]);

	}

	wmb();

	pci_write_config_word(pdev, 4, saved_config_space[2]);



	return 0;

}



/*

 *  This is it.  Find all the controllers and register them.  I really hate

 *  stealing all these major device numbers.
@@ -3404,6 +3601,24 @@ static int __devinit cciss_init_one(struct pci_dev *pdev, 
	int dac, return_code;

	InquiryData_struct *inq_buff = NULL;



	if (reset_devices) {

		/* Reset the controller with a PCI power-cycle */

		if (cciss_hard_reset_controller(pdev) || cciss_reset_msi(pdev))

			return -ENODEV;



		/* Some devices (notably the HP Smart Array 5i Controller)

		   need a little pause here */

		schedule_timeout_uninterruptible(30*HZ);



		/* Now try to get the controller to respond to a no-op */

		for (i=0; i<12; i++) {

			if (cciss_noop(pdev) == 0)

				break;

			else

				printk("cciss: no-op failed%s\n", (i < 11 ? "; re-trying" : ""));

		}

	}



	i = alloc_cciss_hba();

	if (i < 0)

		return -1;

CRA Git | Maintained and supported by SUSTech CRA and CCSE