lightnvm: remove set but not used variables 'data_len' and 'rq_len' (ba6f7da9) · Commits · 戴 / test

drivers/lightnvm/pblk-read.c: In function pblk_submit_read_gc: drivers/lightnvm/pblk-read.c:423:6: warning: variable data_len set but not used [-Wunused-but-set-variable] drivers/lightnvm/pblk-recovery.c: In function pblk_recov_scan_oob: drivers/lightnvm/pblk-recovery.c:368:15: warning: variable rq_len set but not used [-Wunused-but-set-variable] They are not used since commit ("lightnvm: move metadata mapping to lower level driver") Reported-by:

Hulk Robot <hulkci@huawei.com> Signed-off-by:

YueHaibing <yuehaibing@huawei.com> Signed-off-by:

Jens Axboe <axboe@kernel.dk>

drivers/lightnvm/pblk-read.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -420,7 +420,6 @@ int pblk_submit_read_gc(struct pblk pblk, struct pblk_gc_rq gc_rq)
		struct nvm_tgt_dev *dev = pblk->dev;
		struct nvm_geo *geo = &dev->geo;
		struct nvm_rq rqd;
		int data_len;
		int ret = NVM_IO_OK;

		memset(&rqd, 0, sizeof(struct nvm_rq));
		@@ -445,7 +444,6 @@ int pblk_submit_read_gc(struct pblk pblk, struct pblk_gc_rq gc_rq)
		if (!(gc_rq->secs_to_gc))
		goto out;

		data_len = (gc_rq->secs_to_gc) * geo->csecs;
		rqd.opcode = NVM_OP_PREAD;
		rqd.nr_ppas = gc_rq->secs_to_gc;

drivers/lightnvm/pblk-recovery.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -365,7 +365,7 @@ static int pblk_recov_scan_oob(struct pblk pblk, struct pblk_line line,
		__le64 *lba_list;
		u64 paddr = pblk_line_smeta_start(pblk, line) + lm->smeta_sec;
		bool padded = false;
		int rq_ppas, rq_len;
		int rq_ppas;
		int i, j;
		int ret;
		u64 left_ppas = pblk_sec_in_open_line(pblk, line) - lm->smeta_sec;
		@@ -388,7 +388,6 @@ next_rq:
		rq_ppas = pblk_calc_secs(pblk, left_ppas, 0, false);
		if (!rq_ppas)
		rq_ppas = pblk->min_write_pgs;
		rq_len = rq_ppas * geo->csecs;

		retry_rq:
		rqd->bio = NULL;

Admin message