Commit ba6b8de4 authored by John Fastabend's avatar John Fastabend Committed by Daniel Borkmann
Browse files

bpf: sockmap, map_release does not hold refcnt for pinned maps 



Relying on map_release hook to decrement the reference counts when a
map is removed only works if the map is not being pinned. In the
pinned case the ref is decremented immediately and the BPF programs
released. After this BPF programs may not be in-use which is not
what the user would expect.

This patch moves the release logic into bpf_map_put_uref() and brings
sockmap in-line with how a similar case is handled in prog array maps.

Fixes: 3d9e9526 ("bpf: sockmap, fix leaking maps with attached but not detached progs")
Signed-off-by: default avatarJohn Fastabend <john.fastabend@gmail.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
parent 4dfe1bb9

include/linux/bpf.h

+1 −1
Original line number Diff line number Diff line
@@ -31,6 +31,7 @@ struct bpf_map_ops { 
	void (*map_release)(struct bpf_map *map, struct file *map_file);

	void (*map_free)(struct bpf_map *map);

	int (*map_get_next_key)(struct bpf_map *map, void *key, void *next_key);

	void (*map_release_uref)(struct bpf_map *map);



	/* funcs callable from userspace and from eBPF programs */

	void *(*map_lookup_elem)(struct bpf_map *map, void *key);
@@ -436,7 +437,6 @@ int bpf_stackmap_copy(struct bpf_map *map, void *key, void *value); 
int bpf_fd_array_map_update_elem(struct bpf_map *map, struct file *map_file,

				 void *key, void *value, u64 map_flags);

int bpf_fd_array_map_lookup_elem(struct bpf_map *map, void *key, u32 *value);

void bpf_fd_array_map_clear(struct bpf_map *map);

int bpf_fd_htab_map_update_elem(struct bpf_map *map, struct file *map_file,

				void *key, void *value, u64 map_flags);

int bpf_fd_htab_map_lookup_elem(struct bpf_map *map, void *key, u32 *value);

kernel/bpf/arraymap.c

+2 −1
Original line number Diff line number Diff line
@@ -476,7 +476,7 @@ static u32 prog_fd_array_sys_lookup_elem(void *ptr) 
}



/* decrement refcnt of all bpf_progs that are stored in this map */

void bpf_fd_array_map_clear(struct bpf_map *map)

static void bpf_fd_array_map_clear(struct bpf_map *map)

{

	struct bpf_array *array = container_of(map, struct bpf_array, map);

	int i;
@@ -495,6 +495,7 @@ const struct bpf_map_ops prog_array_map_ops = { 
	.map_fd_get_ptr = prog_fd_array_get_ptr,

	.map_fd_put_ptr = prog_fd_array_put_ptr,

	.map_fd_sys_lookup_elem = prog_fd_array_sys_lookup_elem,

	.map_release_uref = bpf_fd_array_map_clear,

};



static struct bpf_event_entry *bpf_event_entry_gen(struct file *perf_file,

kernel/bpf/sockmap.c

+2 −2
Original line number Diff line number Diff line
@@ -1831,7 +1831,7 @@ static int sock_map_update_elem(struct bpf_map *map, 
	return err;

}



static void sock_map_release(struct bpf_map *map, struct file *map_file)

static void sock_map_release(struct bpf_map *map)

{

	struct bpf_stab *stab = container_of(map, struct bpf_stab, map);

	struct bpf_prog *orig;
@@ -1855,7 +1855,7 @@ const struct bpf_map_ops sock_map_ops = { 
	.map_get_next_key = sock_map_get_next_key,

	.map_update_elem = sock_map_update_elem,

	.map_delete_elem = sock_map_delete_elem,

	.map_release = sock_map_release,

	.map_release_uref = sock_map_release,

};



BPF_CALL_4(bpf_sock_map_update, struct bpf_sock_ops_kern *, bpf_sock,

kernel/bpf/syscall.c

+2 −2
Original line number Diff line number Diff line
@@ -257,8 +257,8 @@ static void bpf_map_free_deferred(struct work_struct *work) 
static void bpf_map_put_uref(struct bpf_map *map)

{

	if (atomic_dec_and_test(&map->usercnt)) {

		if (map->map_type == BPF_MAP_TYPE_PROG_ARRAY)

			bpf_fd_array_map_clear(map);

		if (map->ops->map_release_uref)

			map->ops->map_release_uref(map);

	}

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE