kbuild: move "_all" target out of $(KBUILD_SRC) conditional (ba634ece) · Commits · 戴 / test

The first "_all" occurrence around line 120 is only visible when KBUILD_SRC is unset. If O=... is specified, the working directory is relocated, then the only second occurrence around line 193 is visible, that is not set to PHONY. Move the first one to an always visible place. This clarifies "_all" is our default target and it is always set to PHONY. Signed-off-by:

Masahiro Yamada <yamada.masahiro@socionext.com> Reviewed-by:

Douglas Anderson <dianders@chromium.org>

Makefile

+4 −4

Original line number	Diff line number	Diff line
		@@ -10,6 +10,10 @@ NAME = Fearless Coyote
		# Comments in this file are targeted only to the developer, do not
		# expect to learn how to build the kernel reading this file.

		# That's our default target when none is given on the command line
		PHONY := _all
		_all:

		# o Do not use make's built-in rules and variables
		# (this increases performance and avoids hard-to-debug behaviour);
		# o Look for make include files relative to root of kernel src
		@@ -116,10 +120,6 @@ ifeq ("$(origin O)", "command line")
		KBUILD_OUTPUT := $(O)
		endif

		# That's our default target when none is given on the command line
		PHONY := _all
		_all:

		# Cancel implicit rules on top Makefile
		$(CURDIR)/Makefile Makefile: ;

Admin message