CIFS: Warn less noisily on default mount (ba55344f) · Commits · 戴 / test

The warning we print on mount about how to use less secure dialects (when the user does not specify a version on mount) is useful but is noisy to print on every default mount, and can be changed to a warn_once. Slightly updated the warning text as well to note SMB3.1.1 which has been the default which is typically negotiated (for a few years now) by most servers. "No dialect specified on mount. Default has changed to a more secure dialect, SMB2.1 or later (e.g. SMB3.1.1), from CIFS (SMB1). To use the less secure SMB1 dialect to access old servers which do not support SMB3.1.1 (or even SMB3 or SMB2.1) specify vers=1.0 on mount." Signed-off-by:

Steve French <stfrench@microsoft.com> Acked-by:

Ronnie Sahlberg <lsahlber@redhat.com>

fs/cifs/connect.c

+6 −5

Original line number	Diff line number	Diff line
		@@ -2469,11 +2469,12 @@ cifs_parse_mount_options(const char mountdata, const char devname,
		pr_notice("CIFS: ignoring forcegid mount option specified with no gid= option.\n");

		if (got_version == false)
		pr_warn("No dialect specified on mount. Default has changed to "
		"a more secure dialect, SMB2.1 or later (e.g. SMB3), from CIFS "
		"(SMB1). To use the less secure SMB1 dialect to access "
		"old servers which do not support SMB3 (or SMB2.1) specify vers=1.0"
		" on mount.\n");
		pr_warn_once("No dialect specified on mount. Default has changed"
		" to a more secure dialect, SMB2.1 or later (e.g. "
		"SMB3.1.1), from CIFS (SMB1). To use the less secure "
		"SMB1 dialect to access old servers which do not "
		"support SMB3.1.1 (or even SMB3 or SMB2.1) specify "
		"vers=1.0 on mount.\n");

		kfree(mountdata_copy);
		return 0;

Admin message