Commit ba4b87ad authored by Stanislaw Gruszka's avatar Stanislaw Gruszka Committed by Joerg Roedel
Browse files

dma-debug: print information about leaked entry 



When driver leak dma mapping, print additional information about one of
leaked entries, to to help investigate problem. Patch should be useful
for debugging drivers, which maps many different class of buffers.

Signed-off-by: default avatarStanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: default avatarJoerg Roedel <joerg.roedel@amd.com>
parent 6221f222

lib/dma-debug.c

+13 −5
Original line number Diff line number Diff line
@@ -649,7 +649,7 @@ out_err: 
	return -ENOMEM;

}



static int device_dma_allocations(struct device *dev)

static int device_dma_allocations(struct device *dev, struct dma_debug_entry **out_entry)

{

	struct dma_debug_entry *entry;

	unsigned long flags;
@@ -660,8 +660,10 @@ static int device_dma_allocations(struct device *dev) 
	for (i = 0; i < HASH_SIZE; ++i) {

		spin_lock(&dma_entry_hash[i].lock);

		list_for_each_entry(entry, &dma_entry_hash[i].list, list) {

			if (entry->dev == dev)

			if (entry->dev == dev) {

				count += 1;

				*out_entry = entry;

			}

		}

		spin_unlock(&dma_entry_hash[i].lock);

	}
@@ -674,6 +676,7 @@ static int device_dma_allocations(struct device *dev) 
static int dma_debug_device_change(struct notifier_block *nb, unsigned long action, void *data)

{

	struct device *dev = data;

	struct dma_debug_entry *uninitialized_var(entry);

	int count;



	if (global_disable)
@@ -681,12 +684,17 @@ static int dma_debug_device_change(struct notifier_block *nb, unsigned long acti 


	switch (action) {

	case BUS_NOTIFY_UNBOUND_DRIVER:

		count = device_dma_allocations(dev);

		count = device_dma_allocations(dev, &entry);

		if (count == 0)

			break;

		err_printk(dev, NULL, "DMA-API: device driver has pending "

		err_printk(dev, entry, "DMA-API: device driver has pending "

				"DMA allocations while released from device "

				"[count=%d]\n", count);

				"[count=%d]\n"

				"One of leaked entries details: "

				"[device address=0x%016llx] [size=%llu bytes] "

				"[mapped with %s] [mapped as %s]\n",

			count, entry->dev_addr, entry->size,

			dir2name[entry->direction], type2name[entry->type]);

		break;

	default:

		break;

CRA Git | Maintained and supported by SUSTech CRA and CCSE