Commit ba3efdff authored May 01, 2018 by Dan Carpenter Committed by Linus Walleij May 16, 2018

gpiolib: fix gpiochip_machine_hog()



There is a shifter vs vanilla mask bug here.  We want to test if 1 << 11
is set but we're testing if 0xb is set.

Fixes: 9a6c505f7df1 ("gpiolib: add hogs support for machine code")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Bartosz Golaszewski <brgl@bgdev.pl>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 0c695e38

drivers/gpio/gpiolib.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1186,7 +1186,7 @@ static void gpiochip_machine_hog(struct gpio_chip chip, struct gpiod_hog hog)
		return;
		}

		if (desc->flags & FLAG_IS_HOGGED)
		if (test_bit(FLAG_IS_HOGGED, &desc->flags))
		return;

		rv = gpiod_hog(desc, hog->line_name, hog->lflags, hog->dflags);

Admin message