Commit ba3edf1f authored Dec 06, 2017 by Linus Torvalds

proc: show si_ptr in /proc/<pid>/timers without hashing



It's a user pointer, and while the permissions of the file are pretty
questionable (should it really be readable to everybody), hashing the
pointer isn't going to be the solution.

We should take a closer look at more of the /proc/<pid> file permissions
in general.  Sure, we do want many of them to often be readable (for
'ps' and friends), but I think we should probably do a few conversions
from S_IRUGO to S_IRUSR.

Reported-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 10f837e5

fs/proc/base.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2268,7 +2268,7 @@ static int show_timer(struct seq_file m, void v)
		notify = timer->it_sigev_notify;

		seq_printf(m, "ID: %d\n", timer->it_id);
		seq_printf(m, "signal: %d/%p\n",
		seq_printf(m, "signal: %d/%px\n",
		timer->sigq->info.si_signo,
		timer->sigq->info.si_value.sival_ptr);
		seq_printf(m, "notify: %s/%s.%d\n",

Admin message