Commit ba34d58c authored by Ezequiel Garcia's avatar Ezequiel Garcia Committed by Daniel Vetter
Browse files

drm: probe_helper: Hide ugly ifdef 



Push the ifdef to the drm_edid.h and create a stub, for the
DRM_LOAD_EDID_FIRMWARE=n case. This removes some clutter in
the code, making it more readable.

Signed-off-by: default avatarEzequiel Garcia <ezequiel@vanguardiasur.com.ar>
Reviewed-by: default avatarJani Nikula <jani.nikula@intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1461087638-16959-1-git-send-email-ezequiel@vanguardiasur.com.ar
parent d63c25e4

drivers/gpu/drm/drm_probe_helper.c

+0 −2
Original line number Diff line number Diff line
@@ -264,10 +264,8 @@ int drm_helper_probe_single_connector_modes(struct drm_connector *connector, 
		count = drm_add_edid_modes(connector, edid);

		drm_edid_to_eld(connector, edid);

	} else {

#ifdef CONFIG_DRM_LOAD_EDID_FIRMWARE

		count = drm_load_edid_firmware(connector);

		if (count == 0)

#endif

			count = (*connector_funcs->get_modes)(connector);

	}

include/drm/drm_edid.h

+8 −0
Original line number Diff line number Diff line
@@ -328,7 +328,15 @@ int drm_edid_to_speaker_allocation(struct edid *edid, u8 **sadb); 
int drm_av_sync_delay(struct drm_connector *connector,

		      const struct drm_display_mode *mode);

struct drm_connector *drm_select_eld(struct drm_encoder *encoder);



#ifdef CONFIG_DRM_LOAD_EDID_FIRMWARE

int drm_load_edid_firmware(struct drm_connector *connector);

#else

static inline int drm_load_edid_firmware(struct drm_connector *connector)

{

	return 0;

}

#endif



int

drm_hdmi_avi_infoframe_from_display_mode(struct hdmi_avi_infoframe *frame,

CRA Git | Maintained and supported by SUSTech CRA and CCSE