Commit ba328f82 authored Aug 27, 2020 by Yuqi Jin Committed by Joerg Roedel Sep 04, 2020

iommu/iova: Replace cmpxchg with xchg in queue_iova



The performance of the atomic_xchg is better than atomic_cmpxchg because
no comparison is required. While the value of @fq_timer_on can only be 0
or 1. Let's use atomic_xchg instead of atomic_cmpxchg here because we
only need to check that the value changes from 0 to 1 or from 1 to 1.

Signed-off-by: Yuqi Jin <jinyuqi@huawei.com>
Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Cc: Joerg Roedel <joro@8bytes.org>
Link: https://lore.kernel.org/r/1598517834-30275-1-git-send-email-zhangshaokun@hisilicon.com


Signed-off-by: Joerg Roedel <jroedel@suse.de>

parent 4604393c

drivers/iommu/iova.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -579,7 +579,7 @@ void queue_iova(struct iova_domain *iovad,

		/* Avoid false sharing as much as possible. */
		if (!atomic_read(&iovad->fq_timer_on) &&
		!atomic_cmpxchg(&iovad->fq_timer_on, 0, 1))
		!atomic_xchg(&iovad->fq_timer_on, 1))
		mod_timer(&iovad->fq_timer,
		jiffies + msecs_to_jiffies(IOVA_FQ_TIMEOUT));
		}

Admin message