Commit ba28236e authored Aug 27, 2019 by Markus Elfring Committed by Geert Uytterhoeven Oct 01, 2019

clk: renesas: mstp: Delete unnecessary kfree() in cpg_mstp_clocks_init()



A NULL pointer would be passed to a call of the function kfree()
directly after a call of the function kzalloc() failed at one place.
Remove this superfluous function call.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Link: https://lore.kernel.org/r/e66b822b-026b-29cc-e461-6334aafd1d30@web.de


Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

parent 54ce17dd

drivers/clk/renesas/clk-mstp.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -189,10 +189,8 @@ static void __init cpg_mstp_clocks_init(struct device_node *np)
		unsigned int i;

		group = kzalloc(struct_size(group, clks, MSTP_MAX_CLOCKS), GFP_KERNEL);
		if (group == NULL) {
		kfree(group);
		if (!group)
		return;
		}

		clks = group->clks;
		spin_lock_init(&group->lock);

Admin message