Commit ba0f4d76 authored by Tejun Heo's avatar Tejun Heo
Browse files

cgroup: reorganize cgroup_create() 



Reorganize cgroup_create() so that all paths share unlock out path.

* All err_* labels are renamed to out_* as they're now shared by both
  success and failure paths.

* @err renamed to @ret for the similar reason as above and so that
  it's more consistent with other functions.

* cgroup memory allocation moved after locking so that freeing failed
  cgroup happens before unlocking.  While this moves more code inside
  critical section, memory allocations inside cgroup locking are
  already pretty common and this is unlikely to make any noticeable
  difference.

* While at it, replace a stray @parent->root dereference with @root.

This reorganization will help simplifying locking.

Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Acked-by: default avatarLi Zefan <lizefan@huawei.com>
parent b7fc5ad2

kernel/cgroup.c

+34 −35
Original line number Diff line number Diff line
@@ -4246,15 +4246,10 @@ static long cgroup_create(struct cgroup *parent, const char *name, 
{

	struct cgroup *cgrp;

	struct cgroup_root *root = parent->root;

	int ssid, err;

	int ssid, ret;

	struct cgroup_subsys *ss;

	struct kernfs_node *kn;



	/* allocate the cgroup and its ID, 0 is reserved for the root */

	cgrp = kzalloc(sizeof(*cgrp), GFP_KERNEL);

	if (!cgrp)

		return -ENOMEM;



	mutex_lock(&cgroup_tree_mutex);



	/*
@@ -4265,8 +4260,15 @@ static long cgroup_create(struct cgroup *parent, const char *name, 
	 * don't get nasty surprises if we ever grow another caller.

	 */

	if (!cgroup_lock_live_group(parent)) {

		err = -ENODEV;

		goto err_unlock_tree;

		ret = -ENODEV;

		goto out_unlock_tree;

	}



	/* allocate the cgroup and its ID, 0 is reserved for the root */

	cgrp = kzalloc(sizeof(*cgrp), GFP_KERNEL);

	if (!cgrp) {

		ret = -ENOMEM;

		goto out_unlock;

	}



	/*
@@ -4275,15 +4277,15 @@ static long cgroup_create(struct cgroup *parent, const char *name, 
	 */

	cgrp->id = cgroup_idr_alloc(&root->cgroup_idr, NULL, 2, 0, GFP_NOWAIT);

	if (cgrp->id < 0) {

		err = -ENOMEM;

		goto err_unlock;

		ret = -ENOMEM;

		goto out_free_cgrp;

	}



	init_cgroup_housekeeping(cgrp);



	cgrp->parent = parent;

	cgrp->dummy_css.parent = &parent->dummy_css;

	cgrp->root = parent->root;

	cgrp->root = root;



	if (notify_on_release(parent))

		set_bit(CGRP_NOTIFY_ON_RELEASE, &cgrp->flags);
@@ -4294,8 +4296,8 @@ static long cgroup_create(struct cgroup *parent, const char *name, 
	/* create the directory */

	kn = kernfs_create_dir(parent->kn, name, mode, cgrp);

	if (IS_ERR(kn)) {

		err = PTR_ERR(kn);

		goto err_free_id;

		ret = PTR_ERR(kn);

		goto out_free_id;

	}

	cgrp->kn = kn;
@@ -4318,20 +4320,20 @@ static long cgroup_create(struct cgroup *parent, const char *name, 
	 */

	cgroup_idr_replace(&root->cgroup_idr, cgrp, cgrp->id);



	err = cgroup_kn_set_ugid(kn);

	if (err)

		goto err_destroy;

	ret = cgroup_kn_set_ugid(kn);

	if (ret)

		goto out_destroy;



	err = cgroup_addrm_files(cgrp, cgroup_base_files, true);

	if (err)

		goto err_destroy;

	ret = cgroup_addrm_files(cgrp, cgroup_base_files, true);

	if (ret)

		goto out_destroy;



	/* let's create and online css's */

	for_each_subsys(ss, ssid) {

		if (parent->child_subsys_mask & (1 << ssid)) {

			err = create_css(cgrp, ss);

			if (err)

				goto err_destroy;

			ret = create_css(cgrp, ss);

			if (ret)

				goto out_destroy;

		}

	}
@@ -4344,25 +4346,22 @@ static long cgroup_create(struct cgroup *parent, const char *name, 


	kernfs_activate(kn);



	mutex_unlock(&cgroup_mutex);

	mutex_unlock(&cgroup_tree_mutex);



	return 0;

	ret = 0;

	goto out_unlock;



err_free_id:

out_free_id:

	cgroup_idr_remove(&root->cgroup_idr, cgrp->id);

err_unlock:

out_free_cgrp:

	kfree(cgrp);

out_unlock:

	mutex_unlock(&cgroup_mutex);

err_unlock_tree:

out_unlock_tree:

	mutex_unlock(&cgroup_tree_mutex);

	kfree(cgrp);

	return err;

	return ret;



err_destroy:

out_destroy:

	cgroup_destroy_locked(cgrp);

	mutex_unlock(&cgroup_mutex);

	mutex_unlock(&cgroup_tree_mutex);

	return err;

	goto out_unlock;

}



static int cgroup_mkdir(struct kernfs_node *parent_kn, const char *name,

CRA Git | Maintained and supported by SUSTech CRA and CCSE