Commit ba0c4441 authored Mar 31, 2015 by Vitaly Kuznetsov Committed by Greg Kroah-Hartman Apr 03, 2015

Drivers: hv: hv_balloon: correctly handle val.freeram<num_pages case



'Drivers: hv: hv_balloon: refuse to balloon below the floor' fix does not
correctly handle the case when val.freeram < num_pages as val.freeram is
__kernel_ulong_t and the 'val.freeram - num_pages' value will be a huge
positive value instead of being negative.

Usually host doesn't ask us to balloon more than val.freeram but in case
he have a memory hog started after we post the last pressure report we
can get into troubles.

Suggested-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6a84d63d

drivers/hv/hv_balloon.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1155,7 +1155,7 @@ static void balloon_up(struct work_struct *dummy)
		floor = compute_balloon_floor();

		/* Refuse to balloon below the floor, keep the 2M granularity. */
		if (val.freeram - num_pages < floor) {
		if (val.freeram < num_pages \|\| val.freeram - num_pages < floor) {
		num_pages = val.freeram > floor ? (val.freeram - floor) : 0;
		num_pages -= num_pages % PAGES_IN_2M;
		}

Admin message