Commit b9fe5151 authored by Jaehyun Chung's avatar Jaehyun Chung Committed by Alex Deucher
Browse files

drm/amd/display: DML Validation Dump/Check with Logging 



[Why]
Need validation that we are programming the expected values (rq, ttu, dlg)
from DML. This debug feature will output logs if we are programming
incorrect values and may help differentiate DAL issues from HW issues.

[How]
Dump relevant registers for each pipe with active stream. Compare current
reg values with the converted DML output. Log mismatches when found.

Signed-off-by: default avatarJaehyun Chung <jaehyun.chung@amd.com>
Reviewed-by: default avatarAlvin Lee <Alvin.Lee2@amd.com>
Acked-by: default avatarRodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 78c77382

drivers/gpu/drm/amd/display/dc/core/dc.c

+17 −1
Original line number Diff line number Diff line
@@ -2162,8 +2162,24 @@ static void commit_planes_for_stream(struct dc *dc, 
					dc, pipe_ctx->stream, stream_status->plane_count, context);

		}

	}

	if (dc->hwss.program_front_end_for_ctx && update_type != UPDATE_TYPE_FAST)

	if (dc->hwss.program_front_end_for_ctx && update_type != UPDATE_TYPE_FAST) {

		dc->hwss.program_front_end_for_ctx(dc, context);

#ifdef CONFIG_DRM_AMD_DC_DCN1_0

		if (dc->debug.validate_dml_output) {

			for (i = 0; i < dc->res_pool->pipe_count; i++) {

				struct pipe_ctx cur_pipe = context->res_ctx.pipe_ctx[i];

				if (cur_pipe.stream == NULL)

					continue;



				cur_pipe.plane_res.hubp->funcs->validate_dml_output(

						cur_pipe.plane_res.hubp, dc->ctx,

						&context->res_ctx.pipe_ctx[i].rq_regs,

						&context->res_ctx.pipe_ctx[i].dlg_regs,

						&context->res_ctx.pipe_ctx[i].ttu_regs);

			}

		}

#endif

	}



	// Update Type FAST, Surface updates

	if (update_type == UPDATE_TYPE_FAST) {

drivers/gpu/drm/amd/display/dc/dc.h

+1 −0
Original line number Diff line number Diff line
@@ -412,6 +412,7 @@ struct dc_debug_options { 


	bool nv12_iflip_vm_wa;

	bool disable_dram_clock_change_vactive_support;

	bool validate_dml_output;

};



struct dc_debug_data {

drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hubp.c

+310 −0

File changed.

Preview size limit exceeded, changes collapsed.

drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hubp.c

+345 −0

File changed.

Preview size limit exceeded, changes collapsed.

drivers/gpu/drm/amd/display/dc/inc/hw/hubp.h

+7 −0
Original line number Diff line number Diff line
@@ -157,6 +157,13 @@ struct hubp_funcs { 
		struct hubp *hubp,

		bool enable);



	void (*validate_dml_output)(

			struct hubp *hubp,

			struct dc_context *ctx,

			struct _vcs_dpi_display_rq_regs_st *dml_rq_regs,

			struct _vcs_dpi_display_dlg_regs_st *dml_dlg_attr,

			struct _vcs_dpi_display_ttu_regs_st *dml_ttu_attr);



};



#endif

CRA Git | Maintained and supported by SUSTech CRA and CCSE