Commit b9f2d35f authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda: Unexport some local helper functions 

snd_hdac_bus_queue_event() and snd_hdac_bus_exec_verb() are used only
internally in HD-audio core.  Let's drop the exports and move the
declarations into local.h.

Link: https://lore.kernel.org/r/20200516062854.22141-3-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 6325c7fa

include/sound/hdaudio.h

+0 −3
Original line number Diff line number Diff line
@@ -372,11 +372,8 @@ struct hdac_bus { 
int snd_hdac_bus_init(struct hdac_bus *bus, struct device *dev,

		      const struct hdac_bus_ops *ops);

void snd_hdac_bus_exit(struct hdac_bus *bus);

int snd_hdac_bus_exec_verb(struct hdac_bus *bus, unsigned int addr,

			   unsigned int cmd, unsigned int *res);

int snd_hdac_bus_exec_verb_unlocked(struct hdac_bus *bus, unsigned int addr,

				    unsigned int cmd, unsigned int *res);

void snd_hdac_bus_queue_event(struct hdac_bus *bus, u32 res, u32 res_ex);



static inline void snd_hdac_codec_link_up(struct hdac_device *codec)

{

sound/hda/hdac_bus.c

+0 −2
Original line number Diff line number Diff line
@@ -81,7 +81,6 @@ int snd_hdac_bus_exec_verb(struct hdac_bus *bus, unsigned int addr, 
	mutex_unlock(&bus->cmd_mutex);

	return err;

}

EXPORT_SYMBOL_GPL(snd_hdac_bus_exec_verb);



/**

 * snd_hdac_bus_exec_verb_unlocked - unlocked version
@@ -150,7 +149,6 @@ void snd_hdac_bus_queue_event(struct hdac_bus *bus, u32 res, u32 res_ex) 


	schedule_work(&bus->unsol_work);

}

EXPORT_SYMBOL_GPL(snd_hdac_bus_queue_event);



/*

 * process queued unsolicited events

sound/hda/hdac_controller.c

+1 −0
Original line number Diff line number Diff line
@@ -9,6 +9,7 @@ 
#include <sound/core.h>

#include <sound/hdaudio.h>

#include <sound/hda_register.h>

#include "local.h"



/* clear CORB read pointer properly */

static void azx_clear_corbrp(struct hdac_bus *bus)

sound/hda/local.h

+3 −0
Original line number Diff line number Diff line
@@ -36,6 +36,9 @@ void hda_widget_sysfs_exit(struct hdac_device *codec); 
int snd_hdac_bus_add_device(struct hdac_bus *bus, struct hdac_device *codec);

void snd_hdac_bus_remove_device(struct hdac_bus *bus,

				struct hdac_device *codec);

void snd_hdac_bus_queue_event(struct hdac_bus *bus, u32 res, u32 res_ex);

int snd_hdac_bus_exec_verb(struct hdac_bus *bus, unsigned int addr,

			   unsigned int cmd, unsigned int *res);



int snd_hdac_exec_verb(struct hdac_device *codec, unsigned int cmd,

		       unsigned int flags, unsigned int *res);

CRA Git | Maintained and supported by SUSTech CRA and CCSE