Commit b9ed847b authored Dec 01, 2020 by Quentin Perret Committed by Masahiro Yamada Dec 21, 2020

modpost: turn static exports into error



Using EXPORT_SYMBOL*() on static functions is fundamentally wrong.
Modpost currently reports that as a warning, but clearly this is not a
pattern we should allow, and all in-tree occurences should have been
fixed by now. So, promote the warn() message to error() to make sure
this never happens again.

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Matthias Maennich <maennich@google.com>
Signed-off-by: Quentin Perret <qperret@google.com>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

parent c7299d98

scripts/mod/modpost.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -2648,7 +2648,7 @@ int main(int argc, char **argv)

		for (s = symbolhash[n]; s; s = s->next) {
		if (s->is_static)
		warn("\"%s\" [%s] is a static %s\n",
		error("\"%s\" [%s] is a static %s\n",
		s->name, s->module->name,
		export_str(s->export));
		}

Admin message