Commit b9ec7009 authored Jan 06, 2018 by Colin Ian King Committed by Jiri Kosina Feb 16, 2018

HID: asus: make array 'buf' static const



Don't populate the const read-only array 'buf' on the stack but instead
make it static. Makes the object code smaller by 26 bytes:

Before:
   text	   data	    bss	    dec	    hex	filename
  14378	   2384	     64	  16826	   41ba	linux/drivers/hid/hid-asus.o

After:
   text	   data	    bss	    dec	    hex	filename
  14296	   2440	     64	  16800	   41a0	linux/drivers/hid/hid-asus.o

(gcc version 7.2.0 x86_64)

[jkosina@suse.cz: change commit message slightly]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent 183b6366

drivers/hid/hid-asus.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -570,7 +570,9 @@ static int asus_input_mapping(struct hid_device *hdev,
		static int asus_start_multitouch(struct hid_device *hdev)
		{
		int ret;
		const unsigned char buf[] = { FEATURE_REPORT_ID, 0x00, 0x03, 0x01, 0x00 };
		static const unsigned char buf[] = {
		FEATURE_REPORT_ID, 0x00, 0x03, 0x01, 0x00
		};
		unsigned char *dmabuf = kmemdup(buf, sizeof(buf), GFP_KERNEL);

		if (!dmabuf) {

Admin message