Commit b9e03f18 authored by Bob Peterson's avatar Bob Peterson
Browse files

GFS2: Only set PageChecked for jdata pages 



Before this patch, GFS2 was setting the PageChecked flag for ordered
write pages. This is unnecessary. The ext3 file system only does it
for jdata, and it's only used in jdata circumstances. It only muddies
the already murky waters of writing pages in the aops.

Signed-off-by: default avatarBob Peterson <rpeterso@redhat.com>
parent 9bc980cd

fs/gfs2/aops.c

+4 −4
Original line number Diff line number Diff line
@@ -940,13 +940,13 @@ failed: 
}



/**

 * gfs2_set_page_dirty - Page dirtying function

 * jdata_set_page_dirty - Page dirtying function

 * @page: The page to dirty

 *

 * Returns: 1 if it dirtyed the page, or 0 otherwise

 */

 

static int gfs2_set_page_dirty(struct page *page)

static int jdata_set_page_dirty(struct page *page)

{

	SetPageChecked(page);

	return __set_page_dirty_buffers(page);
@@ -1214,7 +1214,7 @@ static const struct address_space_operations gfs2_ordered_aops = { 
	.readpages = gfs2_readpages,

	.write_begin = gfs2_write_begin,

	.write_end = gfs2_write_end,

	.set_page_dirty = gfs2_set_page_dirty,

	.set_page_dirty = __set_page_dirty_buffers,

	.bmap = gfs2_bmap,

	.invalidatepage = gfs2_invalidatepage,

	.releasepage = gfs2_releasepage,
@@ -1231,7 +1231,7 @@ static const struct address_space_operations gfs2_jdata_aops = { 
	.readpages = gfs2_readpages,

	.write_begin = gfs2_write_begin,

	.write_end = gfs2_write_end,

	.set_page_dirty = gfs2_set_page_dirty,

	.set_page_dirty = jdata_set_page_dirty,

	.bmap = gfs2_bmap,

	.invalidatepage = gfs2_invalidatepage,

	.releasepage = gfs2_releasepage,

CRA Git | Maintained and supported by SUSTech CRA and CCSE