Commit b9d4e714 authored Jan 04, 2012 by Greg Kroah-Hartman

driver core: remove __must_check from device_create_file



With the conversion of the sysdev to a real struct device, more drivers
are calling device_create_file, and some of them don't check the return
value, which isn't wise.

But as they happen to be in parts of the kernel where a warning is
considered an error (i.e. powerpc), this breaks the build.  So for now,
remove the marking on the function, which fixes the build problems.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 3b85e4ab

include/linux/device.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -510,7 +510,7 @@ ssize_t device_store_int(struct device dev, struct device_attribute attr,
		struct dev_ext_attribute dev_attr_##_name = \
		{ __ATTR(_name, _mode, device_show_ulong, device_store_ulong), &(_var) }

		extern int __must_check device_create_file(struct device *device,
		extern int device_create_file(struct device *device,
		const struct device_attribute *entry);
		extern void device_remove_file(struct device *dev,
		const struct device_attribute *attr);

Admin message