Commit b9d17175 authored Feb 26, 2018 by Arkadi Sharshevsky Committed by David S. Miller Feb 27, 2018

devlink: Compare to size_new in case of resource child validation



The current implementation checks the combined size of the children with
the 'size' of the parent. The correct behavior is to check the combined
size vs the pending change and to compare vs the 'size_new'.

Fixes: d9f9b9a4 ("devlink: Add support for resource abstraction")
Signed-off-by: Arkadi Sharshevsky <arkadis@mellanox.com>
Tested-by: Yuval Mintz <yuvalm@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 4c27bf3c

net/core/devlink.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2332,7 +2332,7 @@ devlink_resource_validate_children(struct devlink_resource *resource)
		list_for_each_entry(child_resource, &resource->resource_list, list)
		parts_size += child_resource->size_new;

		if (parts_size > resource->size)
		if (parts_size > resource->size_new)
		size_valid = false;
		out:
		resource->size_valid = size_valid;

Admin message